Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color primitives package #1

Merged
merged 27 commits into from
Apr 29, 2018
Merged

Add color primitives package #1

merged 27 commits into from
Apr 29, 2018

Conversation

broccolini
Copy link
Member

@broccolini broccolini commented Apr 18, 2018 •
edited
Loading

This pr adds primer primitives for use with Primer design system and other projects.

To do:

  • add spacing primitives
  • add typography primitives
  • setup lerna
  • publish color package for mobile team to test

Some follow-up tasks:

  • use storybook or kit to output rendered version of values
  • sass variables package
  • combined js package
  • css package with custom properties ??
  • Mac OS format for use in Keynote etc.
  • test pulling into Figma
  • test pulling into Sketch

cc @shawnbot @jonrohan

@shawnbot
Copy link
Contributor

🤗

@broccolini
add lerna
c6f932f
@broccolini
rename packages
7d704e9
@broccolini
update package name
f94eda9
@broccolini
add spacing primitives package
7d18495
@broccolini
add typography primitives package
67b7482
@broccolini
Publish
e20ab6d 
 - primer-colors@0.0.2-alpha.0
 - primer-spacing@0.0.2-alpha.0
 - primer-typography@0.0.2-alpha.0
@broccolini
remove private 😑
3b22a44
@broccolini
independent versioning
a7d73c8
@broccolini
Publish
17a4428 
 - primer-colors@0.0.2-alpha.2
 - primer-spacing@0.0.2-alpha.2
 - primer-typography@0.0.2-alpha.2
@broccolini
Copy link
Member Author

New modules published at:

I forgot to add readme's so I'll do that next!

@broccolini
add lineHeight to typography primitives
727a5fc
@broccolini
fix whitespace
fcb7947
@broccolini
add combined primitives package
60aec3b
@broccolini
Publish
ec821de 
 - primer-colors@0.0.2-alpha.3
 - primer-primitives@0.0.2-alpha.0
 - primer-spacing@0.0.2-alpha.3
 - primer-typography@0.0.2-alpha.3
@broccolini
add readmes and installation instructions
56baf95
@broccolini
Publish
6d518b8 
 - primer-colors@0.0.2-alpha.4
 - primer-primitives@0.0.2-alpha.1
 - primer-spacing@0.0.2-alpha.4
 - primer-typography@0.0.2-alpha.4
@broccolini
Copy link
Member Author

Added readme's and published a primer-primitives package that imports all the other primitives.

@broccolini broccolini changed the title [WIP] Add color primitives package Add color primitives package Apr 25, 2018
@broccolini broccolini requested a review from shawnbot April 25, 2018 12:36
This was referenced Dec 13, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 20, 2022
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 28, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 4, 2023
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@broccolini @shawnbot