Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding .Counter component when it's empty. #586

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Conversation

jonrohan
Copy link
Member

This change will apply visibility: hidden; to .Counter components when they are empty.

Before
image

After
image

Fixes: https://github.com/github/design-systems/issues/330

/cc @primer/ds-core

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants