Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undeprecate timeline.badgeBg #229

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Undeprecate timeline.badgeBg #229

merged 3 commits into from
Sep 2, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Sep 2, 2021 •
edited
Loading

This undeprecates timeline.badgeBg and adds it back as a "component" variable.

Before After
Screen Shot 2021-09-02 at 12 22 42 Screen Shot 2021-09-02 at 12 22 21
neutral.muted scale.gray.1
Dark Dark Dimmed Dark High Contrast
Screen Shot 2021-09-02 at 12 54 57 Screen Shot 2021-09-02 at 12 55 05 Screen Shot 2021-09-02 at 12 55 15
scale.gray.7 scale.gray.7 scale.gray.7

This is needed because:

  • Using canvas.subtle is too subtle (scale.gray.0)
  • Using neutral.muted doesn't cover the "time line" because it's semi-transparent
  • Using the "gradient hack" doesn't work when color utilites are used, see Revert TimelineItem-badge fix css#1563

In the future we might can consider adding "states" to the TimelineItem-badge component so that no utilities are needed. But that requires some refactoring on dotcom.

@simurai simurai requested a review from a team as a code owner September 2, 2021 03:57
@simurai simurai requested review from jonrohan and removed request for a team September 2, 2021 03:57
@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 2a3f5be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 2, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primitives/8nrZoZE8uiiALZtnf2o8XjXEkPEQ
✅ Preview: https://primitives-git-undeprecate-timeline-badge-bg-primer.vercel.app

@simurai simurai merged commit 6d4dbb0 into main Sep 2, 2021
@simurai simurai deleted the undeprecate-timeline-badge-bg branch September 2, 2021 04:07
@primer-css primer-css mentioned this pull request Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan jonrohan approved these changes

@auareyou auareyou Awaiting requested review from auareyou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @jonrohan