feat(Button): add default type (#2807)

* feat(Button): add default type

* Create .changeset/chilly-knives-impress.md

* test: update snapshots

Co-authored-by: Josh Black <joshblack@users.noreply.github.com>

Author: joshblack

.changeset/chilly-knives-impress.md

@@ -0,0 +1,5 @@
+---
+"@primer/react": minor
+---
+
+Add default `type="button"` for `Button`. This removes the implicit `type="submit"` for a `<button>` and requires an explicit `type` to change.

src/Button/Button.tsx

@@ -5,7 +5,7 @@ import {ForwardRefComponent as PolymorphicForwardRefComponent} from '../utils/po
 
 const ButtonComponent = forwardRef(({children, ...props}, forwardedRef): JSX.Element => {
   return (
-    <ButtonBase ref={forwardedRef} as="button" {...props}>
+    <ButtonBase ref={forwardedRef} as="button" type="button" {...props}>
       {children}
     </ButtonBase>
   )

src/__tests__/__snapshots__/Button.test.tsx.snap

@@ -104,6 +104,7 @@ exports[`Button renders consistently 1`] = `
 
 <button
   className="c0"
+  type="button"
 />
 `;
 
@@ -227,6 +228,7 @@ exports[`Button styles danger button appropriately 1`] = `
 
 <button
   class="c0"
+  type="button"
 >
   <span
     data-component="text"
@@ -451,6 +453,7 @@ exports[`Button styles invisible button appropriately 1`] = `
 
 <button
   class="c0"
+  type="button"
 >
   <span
     data-component="text"
@@ -581,6 +584,7 @@ exports[`Button styles outline button appropriately 1`] = `
 
 <button
   class="c0"
+  type="button"
 >
   <span
     data-component="text"
@@ -706,6 +710,7 @@ exports[`Button styles primary button appropriately 1`] = `
 
 <button
   class="c0"
+  type="button"
 >
   <span
     data-component="text"