Skip to content

Commit a3af68f

Browse files
committed
Revert "Remove Box usage and sx prop from PageLayout (#6872)"
This reverts commit 4e797ef.
1 parent 24f4a41 commit a3af68f

File tree

8 files changed

+91
-155
lines changed

8 files changed

+91
-155
lines changed

.changeset/gold-geckos-send.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

packages/react/src/PageLayout/PageLayout.dev.stories.module.css

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/react/src/PageLayout/PageLayout.dev.stories.tsx

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import type {Meta, StoryFn} from '@storybook/react-vite'
22
import {Placeholder} from '../Placeholder'
33
import {PageLayout} from './PageLayout'
4-
import classes from './PageLayout.dev.stories.module.css'
54

65
const meta: Meta = {
76
title: 'Components/PageLayout/Dev',
@@ -347,11 +346,11 @@ export const Default: StoryFn = args => (
347346
padding={args.padding}
348347
rowGap={args.rowGap}
349348
columnGap={args.columnGap}
350-
className={classes.DebugPageLayout}
349+
sx={{border: '1px solid red'}}
351350
>
352351
<PageLayout.Header
353352
padding={args['Header.padding']}
354-
className={classes.SuccessColor}
353+
sx={{color: 'var(--fgColor-success)'}}
355354
divider={{
356355
narrow: args['Header.divider.narrow'],
357356
regular: args['Header.divider.regular'],
@@ -366,7 +365,7 @@ export const Default: StoryFn = args => (
366365
<Placeholder height={args['Header placeholder height']} label="Header" />
367366
</PageLayout.Header>
368367
<PageLayout.Content
369-
className={classes.SuccessColor}
368+
sx={{color: 'var(--fgColor-success)'}}
370369
width={args['Content.width']}
371370
padding={args['Content.padding']}
372371
hidden={{
@@ -378,7 +377,7 @@ export const Default: StoryFn = args => (
378377
<Placeholder height={args['Content placeholder height']} label="Content" />
379378
</PageLayout.Content>
380379
<PageLayout.Pane
381-
className={classes.SuccessColor}
380+
sx={{color: 'var(--fgColor-success)'}}
382381
position={{
383382
narrow: args['Pane.position.narrow'],
384383
regular: args['Pane.position.regular'],
@@ -403,7 +402,7 @@ export const Default: StoryFn = args => (
403402
<Placeholder height={args['Pane placeholder height']} label="Pane" />
404403
</PageLayout.Pane>
405404
<PageLayout.Footer
406-
className={classes.SuccessColor}
405+
sx={{color: 'var(--fgColor-success)'}}
407406
padding={args['Footer.padding']}
408407
divider={{
409408
narrow: args['Footer.divider.narrow'],

packages/react/src/PageLayout/PageLayout.module.css

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -325,23 +325,3 @@ body[data-page-layout-dragging='true'] * {
325325
/* stylelint-disable-next-line primer/spacing */
326326
padding: var(--spacing);
327327
}
328-
329-
.DraggableHandle {
330-
position: absolute;
331-
inset: 0 -2px;
332-
cursor: col-resize;
333-
background-color: transparent;
334-
transition-delay: 0.1s;
335-
}
336-
337-
.DraggableHandle:hover {
338-
background-color: var(--bgColor-neutral-muted);
339-
}
340-
341-
.DraggableHandle[data-dragging='true'] {
342-
background-color: var(--bgColor-accent-emphasis);
343-
}
344-
345-
.DraggableHandle[data-dragging='true']:hover {
346-
background-color: var(--bgColor-accent-emphasis);
347-
}

packages/react/src/PageLayout/PageLayout.stories.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,7 @@ export const Default: StoryFn = args => (
349349
padding={args.padding}
350350
rowGap={args.rowGap}
351351
columnGap={args.columnGap}
352+
sx={args.sx}
352353
>
353354
{args['Render header?'] ? (
354355
<PageLayout.Header

0 commit comments

Comments
 (0)