Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type tests for Primer colors for border*Color properties #3641

Closed
gr2m opened this issue Aug 15, 2023 · 1 comment
Closed

Add type tests for Primer colors for border*Color properties #3641

gr2m opened this issue Aug 15, 2023 · 1 comment
Assignees

Comments

@gr2m
Copy link
Contributor

gr2m commented Aug 15, 2023

follow up to #3619

@mattcosta7 shared some details

there are some other type-tests in the repo. I think since we're exposing a type that used in many places, it would be good to have some way to validate it, and ensure it's inclusive of all possible options.

I don't think tsd is used in the repo, but might be valuable to add something like it for type only assertions?

right now I think most type tests just ensure functions compile correctly - there's a bunch of files with .types.test suffixes where we do type only tests

in this comment

@gr2m gr2m self-assigned this Aug 15, 2023
Copy link
Contributor

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 15, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants