Skip to content

Conversation

@TylerJDev
Copy link
Member

Reverts #7399

Causes a slight visual regression in ControlGroup (adds additional spacing). Let's address the issue in Dotcom first before shipping this change.

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

⚠️ No Changeset found

Latest commit: 8c0454a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Jan 7, 2026
@TylerJDev TylerJDev marked this pull request as ready for review January 7, 2026 16:18
@TylerJDev TylerJDev requested a review from a team as a code owner January 7, 2026 16:18
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the addition of overflow: hidden to the .StatusTextItem CSS rule in ToggleSwitch, which was introduced in #7399. The revert is necessary because the original change caused a visual regression in ControlGroup by adding unwanted spacing. The team plans to address the underlying issue in Dotcom before reapplying this CSS change.

Key Changes:

  • Removes overflow: hidden from .StatusTextItem:where([data-hidden='true']) in ToggleSwitch CSS
  • Deletes the associated changeset file that documented the original change

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/react/src/ToggleSwitch/ToggleSwitch.module.css Removes the overflow: hidden property from the .StatusTextItem rule when hidden
.changeset/swift-keys-thank.md Deletes the changeset file that documented the original addition of overflow: hidden

Review Result: No issues found. This is a clean revert that properly removes the CSS property that caused visual regressions. The changes are minimal and focused, affecting only the specific CSS rule that was previously added. The deletion of the changeset file is appropriate since the original change is being reverted.

Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TylerJDev TylerJDev added the integration-tests: skipped manually Changes in this PR do not require an integration test label Jan 7, 2026
@TylerJDev TylerJDev merged commit 027562e into main Jan 7, 2026
65 checks passed
@TylerJDev TylerJDev deleted the revert-7399-tylerjdev/toggle-switch-overflow-fix branch January 7, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants