-
Notifications
You must be signed in to change notification settings - Fork 648
Revert "ToggleSwitch: Add overflow: hidden to .StatusTextItem"
#7428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "ToggleSwitch: Add overflow: hidden to .StatusTextItem"
#7428
Conversation
)" This reverts commit 06c8320.
|
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reverts the addition of overflow: hidden to the .StatusTextItem CSS rule in ToggleSwitch, which was introduced in #7399. The revert is necessary because the original change caused a visual regression in ControlGroup by adding unwanted spacing. The team plans to address the underlying issue in Dotcom before reapplying this CSS change.
Key Changes:
- Removes
overflow: hiddenfrom.StatusTextItem:where([data-hidden='true'])in ToggleSwitch CSS - Deletes the associated changeset file that documented the original change
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/react/src/ToggleSwitch/ToggleSwitch.module.css |
Removes the overflow: hidden property from the .StatusTextItem rule when hidden |
.changeset/swift-keys-thank.md |
Deletes the changeset file that documented the original addition of overflow: hidden |
Review Result: No issues found. This is a clean revert that properly removes the CSS property that caused visual regressions. The changes are minimal and focused, affecting only the specific CSS rule that was previously added. The deletion of the changeset file is appropriate since the original change is being reverted.
hectahertz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Reverts #7399
Causes a slight visual regression in ControlGroup (adds additional spacing). Let's address the issue in Dotcom first before shipping this change.