Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primer::Beta::Link is missing support for trainling and leading visuals #2981

Closed
HDinger opened this issue Jul 30, 2024 · 1 comment · Fixed by #2982 · May be fixed by #3041
Closed

Primer::Beta::Link is missing support for trainling and leading visuals #2981

HDinger opened this issue Jul 30, 2024 · 1 comment · Fixed by #2982 · May be fixed by #3041
Assignees
@HDinger
Labels
rails

Comments

@HDinger
Copy link
Contributor

HDinger commented Jul 30, 2024 •
edited
Loading

Steps to reproduce

Bildschirmfoto 2024-07-30 um 07 48 27

Current behavior

  • The Link component supports neither a trailing nor a leading visual

Expected behavior

  • There are slots for one leading and one trailing visual defined in the Primer::Beta::Link component
@HDinger HDinger changed the title Primer::Beta::Link is missing support for trainling and leading icons Primer::Beta::Link is missing support for trainling and leading visuals Jul 30, 2024
@HDinger HDinger mentioned this issue Jul 30, 2024
Merged
10 tasks
@lesliecdubs
Copy link
Member

Thanks so much for contributing the PR! Primer engineers have been tagged for review so we'll try to take a look soon.

@HDinger HDinger mentioned this issue Aug 30, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HDinger HDinger

Labels
rails
Projects
None yet
Milestone
No milestone
2 participants
@lesliecdubs @HDinger