Why use SideReal time?

[sambacha]

SideReal Time Problematic?

rmm-core/contracts/libraries/Units.sol

Line 13 in cb7b2ae

uint256 internal constant YEAR = 31556952; // 365.24219 ephemeris day = 1 year, in seconds

Why use SideReal time? Esp. post PoW, Ethereum slot times are deterministic, and sidereal time is meant to help telescopes, the application use is questionable unless I am not seeing something.

Side Real: 31_556_952
Gregorian: 31_556_926

Not implying that this use is insecure or wrong
The difference is small - I am more curious as to the motivation behind its intended use than anything

Cheers

[Alexangelj]

You are right! I did not know about the specifics on this, so there was not an intentional motivation. It looks like the Gregorian would fit this application better so I'll be sure to update the next version

[sambacha]

You are right! I did not know about the specifics on this, so there was not an intentional motivation. It looks like the Gregorian would fit this application better so I'll be sure to update the next version

To be sure this is more pedantic than a serious issue, I was more curious than anything 😄 so thanks for taking the time to answer this question. Thx

[Alexangelj]

I appreciate details like this so the comment made my day