Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring-your-own Node.js optional alternative to Electron-built-in-Node.js #65

Open
jokeyrhyme opened this issue Dec 1, 2015 · 2 comments
Labels

Comments

@jokeyrhyme
Copy link

Is it technically feasible to use an external Node.js executable with Mancy?

I ask because Electron comes with Node.js 4.1.1, and I'm using Node.js 5.1.0 with my own projects. It gets a bit confusing trying to remember which syntax is available in which Node.js version.

Is this something that you'd accept a PR for?

Clarification:

  • Mancy continues to come with Electron-supplied-Node.js, whichever version that is
  • but there's a new setting in Mancy that accepts the absolute path to any modern Node.js executable
@princejwesley
Copy link
Owner

@jokeyrhyme, I accept PR 😄. We just need electron supplied v8 to run mancy. User commands can be executed in remote node.js. we may need to have a socket connection and pass around context and code to run. I am not sure what else break because of this change. we can experiment that.

For now, Use babel to avoid syntax avaliable problem.

@princejwesley
Copy link
Owner

@jokeyrhyme Electron 0.36 backs node 5.1.1/ chrome 47. so we don't have to worry about newer version that electron team constantly upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants