You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So ultimately 0.0.0 is the most sensible general choice.
0.0.0 doesn't align with any of our other tools. This makes it harder to workout what the base version was that the PR is based on. A PR that's based on v1.6.0 and is going to be backdated wouldn't be the same as one based on v2.5 and is going to be merged into the main as a new version.
Ideas / Proposed Solution(s)
Allow PR builds to base their version off of the current package.json. This way PRs would be ${baseVersion}-pr.${pr_num}.${pr_release_num}.${short_sha} resulting in easily identifiable builds.
The text was updated successfully, but these errors were encountered:
Perceived Problem
0.0.0
doesn't align with any of our other tools. This makes it harder to workout what the base version was that the PR is based on. A PR that's based on v1.6.0 and is going to be backdated wouldn't be the same as one based on v2.5 and is going to be merged into the main as a new version.Ideas / Proposed Solution(s)
Allow PR builds to base their version off of the current
package.json
. This way PRs would be${baseVersion}-pr.${pr_num}.${pr_release_num}.${short_sha}
resulting in easily identifiable builds.The text was updated successfully, but these errors were encountered: