Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

Respect Prettier config #101

Closed
DevanB opened this issue Mar 13, 2019 · 4 comments
Closed

Respect Prettier config #101

DevanB opened this issue Mar 13, 2019 · 4 comments

Comments

@DevanB
Copy link
Contributor

DevanB commented Mar 13, 2019

Is your feature request related to a problem? Please describe.
I've noticed while using the yoga scaffold command that the generated files are not respecting my Prettier config (through .prettierrc). Perhaps this is a bug, but more than likely it's a feature request.

Describe the solution you'd like
A possible solution is to have the generation methods notice any Prettier config type (though package.json, .prettierrc, etc.) and respect them. For instance, I don't have semi: false so semicolons should be generated.

Describe alternatives you've considered
Alternatives might include saying only specific prettier config types are recognized. Otherwise, I believe this is an all-or-nothing feature.

@Weakky
Copy link
Contributor

Weakky commented Mar 14, 2019

Fixed by 00f1c12

@DevanB
Copy link
Contributor Author

DevanB commented Mar 14, 2019

Excellent, I'll give it a test when you cut a new version and report back or close the issue :)

@Weakky
Copy link
Contributor

Weakky commented Mar 14, 2019

Released under yoga@0.0.16 🙂

@DevanB
Copy link
Contributor Author

DevanB commented Mar 15, 2019

@Weakky this is working beautifully. Thanks!

@DevanB DevanB closed this as completed Mar 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants