Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

Spinner freezes when create-yoga install template dependencies #79

Closed
Weakky opened this issue Feb 25, 2019 · 3 comments
Closed

Spinner freezes when create-yoga install template dependencies #79

Weakky opened this issue Feb 25, 2019 · 3 comments

Comments

@Weakky
Copy link
Contributor

Weakky commented Feb 25, 2019

No description provided.

@wtrocki
Copy link
Contributor

wtrocki commented Feb 25, 2019

Need node/npm/yarn versions.
Cannot reproduce

Choose a GraphQL server template? minimal-yoga (Basic starter template )
? Where should we scaffold graphql server? ./test
✔ Downloading starter from https://api.github.com/repos/prisma/yoga2/tarball/master
✔ Extracting content to yoga2/packages/create-yoga/test
✔ Installing dependencies 👩‍🚀

Your template has been successfully set up!
  
Here are the next steps to get you started:
  1. Run yarn dev (Starts the GraphQL server)
  2. That's it !

@pantharshit00
Copy link
Contributor

pantharshit00 commented Feb 25, 2019

@wtrocki

This is related to sindresorhus/ora#86

If we want to fix that spinner, we need to change that shellSync to shell, so that we are not blocking the event loop.

Also, I am able to reproduce this. Spinner is basically stuck:
image

@wtrocki
Copy link
Contributor

wtrocki commented Feb 25, 2019

Ah.. Sorry I haven't seen spinner as it installed almost immediately. Now this is trivial fix 🤦‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants