Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split docker & docker-unsupported tests into their own workflow #3386

Open
Jolg42 opened this issue Jan 18, 2023 · 0 comments
Open

Split docker & docker-unsupported tests into their own workflow #3386

Jolg42 opened this issue Jan 18, 2023 · 0 comments
Labels
kind/feature A request for a new feature. topic: ci

Comments

@Jolg42
Copy link
Contributor

Jolg42 commented Jan 18, 2023

docker and docker-unsupported from https://github.com/prisma/ecosystem-tests/blob/dev/.github/workflows/test.yaml

Example:
Usage report: https://github.com/prisma/ecosystem-tests/actions/runs/3942096892/usage
These tests in particular are not fast

docker (almalinux-latest-arm64-openssl-1.1.x, library, ubuntu-20.04) 13m 28s	
docker (almalinux-latest-arm64-openssl-1.1.x, binary, ubuntu-20.04) 10m 39s	

docker (ubuntu-latest-arm64-openssl-3.0.x, library, ubuntu-20.04) 13m 29s
docker (ubuntu-latest-arm64-openssl-3.0.x, binary, ubuntu-20.04) 10m 22s 	

While it doesn't look like an urgent issue for now, we came to some suggestions for the future (Internal Slack):

We could move these tests to their own workflow, so we don't run them for all commits all the time.

At a minimum we could run them

  • Nightly
  • run-on-demand
  • if one of these test file changes

We could also consider running them for integration versions which would be very useful, as if we do any changes where we want these tests to run we would probably create an integration version for that.

@Jolg42 Jolg42 added kind/improvement An improvement to existing feature and code. topic: ci labels Jan 18, 2023
@Jolg42 Jolg42 changed the title Split docker & docker-unsupported tests into their own workflow Split docker & docker-unsupported tests into their own workflow Jan 18, 2023
@Jolg42 Jolg42 added kind/feature A request for a new feature. and removed kind/improvement An improvement to existing feature and code. labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for a new feature. topic: ci
Projects
None yet
Development

No branches or pull requests

1 participant