Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test against the latest node version #897

Closed
divyenduz opened this issue Oct 16, 2020 · 0 comments
Closed

Test against the latest node version #897

divyenduz opened this issue Oct 16, 2020 · 0 comments
Labels
kind/feature A request for a new feature. topic: basic

Comments

@divyenduz
Copy link
Contributor

In E2E CI, we rely on actions/setup-node@v1 to get the node version. However, the action doesn't get the latest node version always and might lag a bit.

It might be worth checking the latest node version eagerly as we had a related issue (which was luckily caught as Heroku was using the latest node version almost instantly prisma/prisma-client-js#907)

Based on the docs, actions/setup-node@v2-beta might already be doing it https://github.com/actions/setup-node#v2-beta

Internal thread: https://prisma-company.slack.com/archives/CRGDU19K6/p1602763906003100?thread_ts=1602532224.038900&cid=CRGDU19K6
@divyenduz divyenduz added kind/improvement An improvement to existing feature and code. kind/feature A request for a new feature. and removed kind/improvement An improvement to existing feature and code. labels Oct 16, 2020
@Jolg42 Jolg42 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature A request for a new feature. topic: basic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@janpio @divyenduz @Jolg42