Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

Confirmation answer ignored on graphcool delete #735

Closed
l-catallo opened this issue Oct 6, 2017 · 4 comments
Closed

Confirmation answer ignored on graphcool delete #735

l-catallo opened this issue Oct 6, 2017 · 4 comments

Comments

@l-catallo
Copy link

l-catallo commented Oct 6, 2017

When issuing the graphcool delete command the project is deleted regardless of the user's input.

image

I checked and the project was actually deleted. The same thing happens if I don't type anything.

Version info: graphcool/0.6.0-beta.3 (linux-x64) node-v8.6.0

Edit: Typing y cancel the deletion

@marktani
Copy link
Contributor

marktani commented Oct 6, 2017

Thanks for the report!

The same thing happens if I don't type anything.

what do you mean with this?

@l-catallo
Copy link
Author

The same thing happens if I don't type anything.

what do you mean with this?

If I press enter without typing a response the default behavior should be to cancel the operation (as the message says). Right now the project is deleted anyway.

@kbrandwijk
Copy link
Contributor

Maybe the text should be updates to 'Are you sure you want to keep cj....?' or 'Do you not want to delete cj....?' or 'Do you confirm that you don't want to stop keeping access to cj...?' 😈 🤣

@timsuchanek
Copy link
Contributor

This is fixed now, the code simply confused y with n.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants