-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
THIS LIBRARY IS DEAD / NO LONGER FUNCTIONS PROPERLY -- DO NOT USE!! #119
Comments
I totally agree, since the owner is not accepting PR's can we fork it, make the mentioned corrections and try to publish new corrected updated release ? |
Let's do that |
Thanks! I'm using expo with managed workflow, so I had to create a expo-module, and I create a example app to test and it works with the new "TelephonyCallBack.CallStateListener" method from android and CXCallObserver from iOS: https://github.com/benomzn/twilio-voice-exposdk51-example The example is to basic, but maybe you can check the Kotlin code and write your own solution |
What other alternatives have you come across that provides this kind of functionality? I am looking for a simple way to detect call state - incoming, dialing, connected. And the phone number for Andriod. Please let me know! |
has anyone done any work on this? I need this library but i also want to update my code base |
1 similar comment
has anyone done any work on this? I need this library but i also want to update my code base |
did you get the solution |
This library hasn't been updated in 4 years, and there are tons of open PRs and issues, I would suggest people steer clear of this library!
Personally, I'm probably going to fork the library and leave it as is on iOS since it works just fine, and fix the permission stuff on Android.
Summary of the issues I ran into so far on Android:
no types so hard to use in typescript
readPhoneNumberAndroid must be true.
WHY: This library is really old, and back in the day the phone state permission was only
needed if you wanted to read the caller's phone number; now it's needed
for this listener to work at all. If this is not true, it skips the
permission check which leads to a crash.
if the user denies the permissions, you get a crash (surrounding call to the lib w/ try-catch does nothing)
permission denied callback never fires (probably because of the crash)
permissionMessage shows up as non-properly skinned dialog (ie if in dark mode title + bg are white on white)
phone number never given even if you set readPhoneNumberAndroid (in Android 11 they added a new permission for this, which I haven't tried, but I'm guessing this library doesn't request that permission, only READ_PHONE_STATE, so probably won't work out of the box)
permission request to users is scary and wrong: READ_PHONE_STATE allows read only access to phone state, but the system popup when requesting the permission say "Allow to make and manage phone calls", which is wrong.
NOTE: seems to work fine on iOS
The text was updated successfully, but these errors were encountered: