forked from zcash/halo2
-
Notifications
You must be signed in to change notification settings - Fork 129
/
failure.rs
606 lines (572 loc) · 20.8 KB
/
failure.rs
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
use std::collections::{BTreeMap, HashSet};
use std::fmt::{self, Debug};
use group::ff::Field;
use halo2curves::FieldExt;
use super::metadata::DebugVirtualCell;
use super::MockProver;
use super::{
metadata,
util::{self, AnyQuery},
Region,
};
use crate::dev::metadata::Constraint;
use crate::{
dev::{Instance, Value},
plonk::{Any, Column, ConstraintSystem, Expression, Gate},
poly::Rotation,
};
mod emitter;
/// The location within the circuit at which a particular [`VerifyFailure`] occurred.
#[derive(Debug, PartialEq, Eq, Clone)]
pub enum FailureLocation<'a> {
/// A location inside a region.
InRegion {
/// The region in which the failure occurred.
region: metadata::Region<'a>,
/// The offset (relative to the start of the region) at which the failure
/// occurred.
offset: usize,
},
/// A location outside of a region.
OutsideRegion {
/// The circuit row on which the failure occurred.
row: usize,
},
}
impl<'a> fmt::Display for FailureLocation<'a> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Self::InRegion { region, offset } => write!(f, "in {} at offset {}", region, offset),
Self::OutsideRegion { row } => {
write!(f, "outside any region, on row {}", row)
}
}
}
}
impl<'a> FailureLocation<'a> {
pub(super) fn find_expressions<F: Field>(
cs: &ConstraintSystem<F>,
regions: &'a [Region],
failure_row: usize,
failure_expressions: impl Iterator<Item = &'a Expression<F>>,
) -> Self {
let failure_columns: HashSet<Column<Any>> = failure_expressions
.flat_map(|expression| {
expression.evaluate(
&|_| vec![],
&|_| panic!("virtual selectors are removed during optimization"),
&|query| vec![cs.fixed_queries[query.index].0.into()],
&|query| vec![cs.advice_queries[query.index].0.into()],
&|query| vec![cs.instance_queries[query.index].0.into()],
&|_| vec![],
&|a| a,
&|mut a, mut b| {
a.append(&mut b);
a
},
&|mut a, mut b| {
a.append(&mut b);
a
},
&|a, _| a,
)
})
.collect();
Self::find(regions, failure_row, failure_columns)
}
/// Figures out whether the given row and columns overlap an assigned region.
pub(super) fn find(
regions: &'a [Region],
failure_row: usize,
failure_columns: HashSet<Column<Any>>,
) -> Self {
regions
.iter()
.enumerate()
.find(|(_, r)| {
let (start, end) = r.rows.unwrap();
// We match the region if any input columns overlap, rather than all of
// them, because matching complex selector columns is hard. As long as
// regions are rectangles, and failures occur due to assignments entirely
// within single regions, "any" will be equivalent to "all". If these
// assumptions change, we'll start getting bug reports from users :)
(start..=end).contains(&failure_row) && !failure_columns.is_disjoint(&r.columns)
})
.map(|(r_i, r)| FailureLocation::InRegion {
region: (r_i, r.name.clone(), &r.annotations).into(),
offset: failure_row - r.rows.unwrap().0,
})
.unwrap_or_else(|| FailureLocation::OutsideRegion { row: failure_row })
}
}
/// The reasons why a particular circuit is not satisfied.
#[derive(PartialEq, Eq)]
pub enum VerifyFailure<'a> {
/// A cell used in an active gate was not assigned to.
CellNotAssigned {
/// The index of the active gate.
gate: metadata::Gate,
/// The region in which this cell should be assigned.
region: metadata::Region<'a>,
/// The offset (relative to the start of the region) at which the active gate
/// queries this cell.
gate_offset: usize,
/// The column in which this cell should be assigned.
column: Column<Any>,
/// The offset (relative to the start of the region) at which this cell should be
/// assigned. This may be negative (for example, if a selector enables a gate at
/// offset 0, but the gate uses `Rotation::prev()`).
offset: isize,
},
/// A constraint was not satisfied for a particular row.
ConstraintNotSatisfied {
/// The polynomial constraint that is not satisfied.
constraint: metadata::Constraint,
/// The location at which this constraint is not satisfied.
///
/// `FailureLocation::OutsideRegion` is usually caused by a constraint that does
/// not contain a selector, and as a result is active on every row.
location: FailureLocation<'a>,
/// The values of the virtual cells used by this constraint.
cell_values: Vec<(metadata::VirtualCell, String)>,
},
/// A constraint was active on an unusable row, and is likely missing a selector.
ConstraintPoisoned {
/// The polynomial constraint that is not satisfied.
constraint: metadata::Constraint,
},
/// A lookup input did not exist in its corresponding table.
Lookup {
/// The name of the lookup that is not satisfied.
name: &'static str,
/// The index of the lookup that is not satisfied. These indices are assigned in
/// the order in which `ConstraintSystem::lookup` is called during
/// `Circuit::configure`.
lookup_index: usize,
/// The location at which the lookup is not satisfied.
///
/// `FailureLocation::InRegion` is most common, and may be due to the intentional
/// use of a lookup (if its inputs are conditional on a complex selector), or an
/// unintentional lookup constraint that overlaps the region (indicating that the
/// lookup's inputs should be made conditional).
///
/// `FailureLocation::OutsideRegion` is uncommon, and could mean that:
/// - The input expressions do not correctly constrain a default value that exists
/// in the table when the lookup is not being used.
/// - The input expressions use a column queried at a non-zero `Rotation`, and the
/// lookup is active on a row adjacent to an unrelated region.
location: FailureLocation<'a>,
},
/// A permutation did not preserve the original value of a cell.
Permutation {
/// The column in which this permutation is not satisfied.
column: metadata::Column,
/// The location at which the permutation is not satisfied.
location: FailureLocation<'a>,
},
}
impl<'a> fmt::Display for VerifyFailure<'a> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Self::CellNotAssigned {
gate,
region,
gate_offset,
column,
offset,
} => {
write!(
f,
"{} uses {} at offset {}, which requires cell in column {:?} at offset {} to be assigned.",
region, gate, gate_offset, column, offset
)
}
Self::ConstraintNotSatisfied {
constraint,
location,
cell_values,
} => {
writeln!(f, "{} is not satisfied {}", constraint, location)?;
for (dvc, value) in cell_values.iter().map(|(vc, string)| {
let ann_map = match location {
FailureLocation::InRegion { region, offset: _ } => {
region.column_annotations
}
_ => None,
};
(DebugVirtualCell::from((vc, ann_map)), string)
}) {
let _ = writeln!(f, "- {} = {}", dvc, value);
}
Ok(())
}
Self::ConstraintPoisoned { constraint } => {
write!(
f,
"{} is active on an unusable row - missing selector?",
constraint
)
}
Self::Lookup {
name,
lookup_index,
location,
} => {
write!(
f,
"Lookup {}(index: {}) is not satisfied {}",
name, lookup_index, location
)
}
Self::Permutation { column, location } => {
write!(
f,
"Equality constraint not satisfied by cell ({:?}, {})",
column, location
)
}
}
}
}
impl<'a> Debug for VerifyFailure<'a> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
VerifyFailure::ConstraintNotSatisfied {
constraint,
location,
cell_values,
} => {
#[derive(Debug)]
struct ConstraintCaseDebug<'a> {
constraint: Constraint,
location: FailureLocation<'a>,
cell_values: Vec<(DebugVirtualCell, String)>,
}
let ann_map = match location {
FailureLocation::InRegion { region, offset: _ } => region.column_annotations,
_ => None,
};
let debug = ConstraintCaseDebug {
constraint: *constraint,
location: location.clone(),
cell_values: cell_values
.iter()
.map(|(vc, value)| (DebugVirtualCell::from((vc, ann_map)), value.clone()))
.collect(),
};
write!(f, "{:#?}", debug)
}
_ => write!(f, "{:#?}", self),
}
}
}
/// Renders `VerifyFailure::CellNotAssigned`.
///
/// ```text
/// error: cell not assigned
/// Cell layout in region 'Faulty synthesis':
/// | Offset | A0 | A1 |
/// +--------+----+----+
/// | 0 | x0 | |
/// | 1 | | X | <--{ X marks the spot! 🦜
///
/// Gate 'Equality check' (applied at offset 1) queries these cells.
/// ```
fn render_cell_not_assigned<F: Field>(
gates: &[Gate<F>],
gate: &metadata::Gate,
region: &metadata::Region,
gate_offset: usize,
column: Column<Any>,
offset: isize,
) {
// Collect the necessary rendering information:
// - The columns involved in this gate.
// - How many cells are in each column.
// - The grid of cell values, indexed by rotation.
let mut columns = BTreeMap::<metadata::Column, usize>::default();
let mut layout = BTreeMap::<i32, BTreeMap<metadata::Column, _>>::default();
for (i, cell) in gates[gate.index].queried_cells().iter().enumerate() {
let cell_column = cell.column.into();
*columns.entry(cell_column).or_default() += 1;
layout
.entry(cell.rotation.0)
.or_default()
.entry(cell_column)
.or_insert_with(|| {
if cell.column == column && gate_offset as i32 + cell.rotation.0 == offset as i32 {
"X".to_string()
} else {
format!("x{}", i)
}
});
}
eprintln!("error: cell not assigned");
emitter::render_cell_layout(
" ",
&FailureLocation::InRegion {
region: region.clone(),
offset: gate_offset,
},
&columns,
&layout,
|row_offset, rotation| {
if (row_offset.unwrap() + rotation) as isize == offset {
eprint!(" <--{{ X marks the spot! 🦜");
}
},
);
eprintln!();
eprintln!(
" Gate '{}' (applied at offset {}) queries these cells.",
gate.name, gate_offset
);
}
/// Renders `VerifyFailure::ConstraintNotSatisfied`.
///
/// ```text
/// error: constraint not satisfied
/// Cell layout in region 'somewhere':
/// | Offset | A0 |
/// +--------+----+
/// | 0 | x0 | <--{ Gate 'foo' applied here
/// | 1 | x1 |
///
/// Constraint 'bar':
/// x1 + x1 * 0x100 + x1 * 0x10000 + x1 * 0x100_0000 - x0 = 0
///
/// Assigned cell values:
/// x0 = 0x5
/// x1 = 0x5
/// ```
fn render_constraint_not_satisfied<F: Field>(
gates: &[Gate<F>],
constraint: &metadata::Constraint,
location: &FailureLocation,
cell_values: &[(metadata::VirtualCell, String)],
) {
// Collect the necessary rendering information:
// - The columns involved in this constraint.
// - How many cells are in each column.
// - The grid of cell values, indexed by rotation.
let mut columns = BTreeMap::<metadata::Column, usize>::default();
let mut layout = BTreeMap::<i32, BTreeMap<metadata::Column, _>>::default();
for (i, (cell, _)) in cell_values.iter().enumerate() {
*columns.entry(cell.column).or_default() += 1;
layout
.entry(cell.rotation)
.or_default()
.entry(cell.column)
.or_insert(format!("x{}", i));
}
eprintln!("error: constraint not satisfied");
emitter::render_cell_layout(" ", location, &columns, &layout, |_, rotation| {
if rotation == 0 {
eprint!(" <--{{ Gate '{}' applied here", constraint.gate.name);
}
});
// Print the unsatisfied constraint, in terms of the local variables.
eprintln!();
eprintln!(" Constraint '{}':", constraint.name);
eprintln!(
" {} = 0",
emitter::expression_to_string(
&gates[constraint.gate.index].polynomials()[constraint.index],
&layout
)
);
// Print the map from local variables to assigned values.
eprintln!();
eprintln!(" Assigned cell values:");
for (i, (_, value)) in cell_values.iter().enumerate() {
eprintln!(" x{} = {}", i, value);
}
}
/// Renders `VerifyFailure::Lookup`.
///
/// ```text
/// error: lookup input does not exist in table
/// (L0) ∉ (F0)
///
/// Lookup inputs:
/// L0 = x1 * x0 + (1 - x1) * 0x2
/// ^
/// | Cell layout in region 'Faulty synthesis':
/// | | Offset | A0 | F1 |
/// | +--------+----+----+
/// | | 1 | x0 | x1 | <--{ Lookup inputs queried here
/// |
/// | Assigned cell values:
/// | x0 = 0x5
/// | x1 = 1
/// ```
fn render_lookup<F: FieldExt>(
prover: &MockProver<F>,
name: &str,
lookup_index: usize,
location: &FailureLocation,
) {
let n = prover.n as i32;
let cs = &prover.cs;
let lookup = &cs.lookups[lookup_index];
// Get the absolute row on which the lookup's inputs are being queried, so we can
// fetch the input values.
let row = match location {
FailureLocation::InRegion { region, offset } => {
prover.regions[region.index].rows.unwrap().0 + offset
}
FailureLocation::OutsideRegion { row } => *row,
} as i32;
// Recover the fixed columns from the table expressions. We don't allow composite
// expressions for the table side of lookups.
let table_columns = lookup.table_expressions.iter().map(|expr| {
expr.evaluate(
&|_| panic!("no constants in table expressions"),
&|_| panic!("no selectors in table expressions"),
&|query| metadata::Column::from((Any::Fixed, query.column_index)),
&|_| panic!("no advice columns in table expressions"),
&|_| panic!("no instance columns in table expressions"),
&|_| panic!("no challenges in table expressions"),
&|_| panic!("no negations in table expressions"),
&|_, _| panic!("no sums in table expressions"),
&|_, _| panic!("no products in table expressions"),
&|_, _| panic!("no scaling in table expressions"),
)
});
fn cell_value<'a, F: FieldExt, Q: Into<AnyQuery> + Copy>(
load: impl Fn(Q) -> Value<F> + 'a,
) -> impl Fn(Q) -> BTreeMap<metadata::VirtualCell, String> + 'a {
move |query| {
let AnyQuery {
column_type,
column_index,
rotation,
..
} = query.into();
Some((
((column_type, column_index).into(), rotation.0).into(),
match load(query) {
Value::Real(v) => util::format_value(v),
Value::Poison => unreachable!(),
},
))
.into_iter()
.collect()
}
}
eprintln!("error: lookup input does not exist in table");
eprint!(" (");
for i in 0..lookup.input_expressions.len() {
eprint!("{}L{}", if i == 0 { "" } else { ", " }, i);
}
eprint!(") ∉ (");
for (i, column) in table_columns.enumerate() {
eprint!(
"{}{}",
if i == 0 { "" } else { ", " },
prover
.cs
.lookup_annotations
.get(&column)
.cloned()
.unwrap_or_else(|| format!("{}", column))
);
}
eprintln!(")");
eprintln!();
eprintln!(" Lookup '{}' inputs:", name);
for (i, input) in lookup.input_expressions.iter().enumerate() {
// Fetch the cell values (since we don't store them in VerifyFailure::Lookup).
let cell_values = input.evaluate(
&|_| BTreeMap::default(),
&|_| panic!("virtual selectors are removed during optimization"),
&cell_value(&util::load(n, row, &cs.fixed_queries, &prover.fixed)),
&cell_value(&util::load(n, row, &cs.advice_queries, &prover.advice)),
&cell_value(&util::load_instance(
n,
row,
&cs.instance_queries,
&prover.instance,
)),
&|_| BTreeMap::default(),
&|a| a,
&|mut a, mut b| {
a.append(&mut b);
a
},
&|mut a, mut b| {
a.append(&mut b);
a
},
&|a, _| a,
);
// Collect the necessary rendering information:
// - The columns involved in this constraint.
// - How many cells are in each column.
// - The grid of cell values, indexed by rotation.
let mut columns = BTreeMap::<metadata::Column, usize>::default();
let mut layout = BTreeMap::<i32, BTreeMap<metadata::Column, _>>::default();
for (i, (cell, _)) in cell_values.iter().enumerate() {
*columns.entry(cell.column).or_default() += 1;
layout
.entry(cell.rotation)
.or_default()
.entry(cell.column)
.or_insert(format!("x{}", i));
}
if i != 0 {
eprintln!();
}
eprintln!(
" L{} = {}",
i,
emitter::expression_to_string(input, &layout)
);
eprintln!(" ^");
emitter::render_cell_layout(" | ", location, &columns, &layout, |_, rotation| {
if rotation == 0 {
eprint!(" <--{{ Lookup '{}' inputs queried here", name);
}
});
// Print the map from local variables to assigned values.
eprintln!(" |");
eprintln!(" | Assigned cell values:");
for (i, (_, value)) in cell_values.iter().enumerate() {
eprintln!(" | x{} = {}", i, value);
}
}
}
impl<'a> VerifyFailure<'a> {
/// Emits this failure in pretty-printed format to stderr.
pub(super) fn emit<F: FieldExt>(&self, prover: &MockProver<F>) {
match self {
Self::CellNotAssigned {
gate,
region,
gate_offset,
column,
offset,
} => render_cell_not_assigned(
&prover.cs.gates,
gate,
region,
*gate_offset,
*column,
*offset,
),
Self::ConstraintNotSatisfied {
constraint,
location,
cell_values,
} => {
render_constraint_not_satisfied(&prover.cs.gates, constraint, location, cell_values)
}
Self::Lookup {
name,
lookup_index,
location,
} => render_lookup(prover, name, *lookup_index, location),
_ => eprintln!("{}", self),
}
}
}