Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure imt folders in the circuit package #1419

Open
ctrlc03 opened this issue May 2, 2024 · 9 comments
Open

restructure imt folders in the circuit package #1419

ctrlc03 opened this issue May 2, 2024 · 9 comments
Labels
chore Chore tasks good first issue Good for newcomers

Comments

@ctrlc03
Copy link
Collaborator

ctrlc03 commented May 2, 2024

Restructure folders to have one file per each template

@ctrlc03 ctrlc03 added this to MACI May 2, 2024
@ctrlc03 ctrlc03 converted this from a draft issue May 2, 2024
@ctrlc03 ctrlc03 added the chore Chore tasks label May 2, 2024
@ctrlc03 ctrlc03 moved this from Backlog to Todo in MACI May 30, 2024
@ctrlc03 ctrlc03 added the good first issue Good for newcomers label Jul 15, 2024
@0xshikhar
Copy link

Hey @ctrlc03, would love to work on this ?

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Oct 3, 2024

Hey @ctrlc03, would love to work on this ?

sure thing, can assign you @0xshikhar thanks

@crisgarner
Copy link
Collaborator

Hey @0xshikhar, are you still working on this? want to see if we can add it to the hackthoberfest

@0xshikhar
Copy link

Yup, started working on this. Was quite busy due to ETHKL

@0xshikhar
Copy link

Hey @ctrlc03, was working on it and ran the current setup successfully. Just want to confirm - am I working in the right direction : it need restructuring of packages/circuits/ts folder for testing templates ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Oct 17, 2024

Hey @ctrlc03, was working on it and ran the current setup successfully. Just want to confirm - am I working in the right direction : it need restructuring of packages/circuits/ts folder for testing templates ? Could you clarify the remaining tasks for this issue? Any additional context would be appreciated. Thanks!

Hi @0xshikhar - this would be for the circuits folder not the ts code: https://github.com/privacy-scaling-explorations/maci/tree/dev/packages/circuits/circom/trees

@0xshikhar
Copy link

Hi @ctrlc03, i was thinking that it can be incremental merkle tree, but it has only 1 folder. ? Could you clarify the tasks for this issue in detail? Any additional context would be appreciated. Thanks!

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Oct 20, 2024

Hi @ctrlc03, i was thinking that it can be incremental merkle tree, but it has only 1 folder. ? Could you clarify the tasks for this issue in detail? Any additional context would be appreciated. Thanks!

@0xshikhar I believe the original idea of this issue was to have one file for each template inside that folder. So if you open https://github.com/privacy-scaling-explorations/maci/blob/dev/packages/circuits/circom/trees/incrementalMerkleTree.circom you can see there's different templates.

@ctrlc03
Copy link
Collaborator Author

ctrlc03 commented Dec 2, 2024

hi @0xshikhar checking if you still working on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore tasks good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants