Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 Error When .Well Know Not Found #138

Closed
dknopf opened this issue Feb 9, 2021 · 4 comments
Closed

404 Error When .Well Know Not Found #138

dknopf opened this issue Feb 9, 2021 · 4 comments
Assignees

Comments

@dknopf
Copy link
Contributor

dknopf commented Feb 9, 2021

I'm not sure if this is intended or not, but on any site that doesn't have a .well-known/gpc.json file there is a 404 error. This happens even when the extension is disabled via the popup disable button.

image

@SebastianZimmeck
Copy link
Member

Good point, @dknopf. I believe I mentioned that a while back to @kalicki1 and we settled on being OK with those 404s. (There is essentially no way around those, as I see it.)

@dknopf
Copy link
Contributor Author

dknopf commented Feb 9, 2021

Yeah I figured you guys had seen it, I was just wondering if there was some way of suppressing the error and instead printing out a message or something, just so that other developers don't think there's a problem in our code.

@kalicki1
Copy link
Collaborator

So I just took a look at the error, and yes I agree with @SebastianZimmeck that the 404s are probably alright. I would hope developers would be able to see the 404 is on the 1st party's hands for missing a .well-known, not ours. I think the more concerning thing was that the extension would continue to send content scripts regardless of whether OptMeowt was enabled or not. I'm pushing a change that will turn off contentScript.js when the extension is disabled, which shuts off all action on a page for good.

@SebastianZimmeck
Copy link
Member

Maybe, add a sentence to the readme that not finding a .well-known will cause a 404 error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants