Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider building on top of Permissions instead of using the "storage access map" #121

Closed
annevk opened this issue Oct 6, 2022 · 2 comments · Fixed by #138
Closed

Consider building on top of Permissions instead of using the "storage access map" #121

annevk opened this issue Oct 6, 2022 · 2 comments · Fixed by #138
Assignees
Labels
resolve before graduation These issues need to be resolved before the spec graduates from the CG

Comments

@annevk
Copy link
Collaborator

annevk commented Oct 6, 2022

This would allow sharing a bunch of logic around murky concepts such as "user intent".

(There's also some related problems with regards to scope of the grant. Currently the specification uses the agent cluster for this, but there's talk about changing it back to WebKit's original model of document. We should probably track that separately.)

@Brandr0id
Copy link
Member

+1, to this. This would also reflect the implementation in Edge/Chromium that leverages the permissions system for managing any prompts as it can leverage other permissions mechanisms for stopping nuisance prompts and holistically seeing if the site(s) in question are also requesting other permissions/prompts.

@johannhof
Copy link
Member

As mentioned in #122 I think this is what we should do to reflect the reality in both Firefox and Chrome and also because it fits well onto the per-frame model where the browser maintains an "storage access when requested" permission and a separate "storage access" map on the browsing context. The "storage access when requested" permission could be queried through permissions API or watched through permissionStatus.onchange. This would also solve #55.

@johannhof johannhof added the resolve before graduation These issues need to be resolved before the spec graduates from the CG label Oct 10, 2022
@johannhof johannhof added the agenda+ Request to add this issue to the agenda of our next telcon or F2F label Oct 12, 2022
@erik-anderson erik-anderson removed the agenda+ Request to add this issue to the agenda of our next telcon or F2F label Nov 15, 2022
@johannhof johannhof self-assigned this Nov 18, 2022
@johannhof johannhof linked a pull request Dec 6, 2022 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolve before graduation These issues need to be resolved before the spec graduates from the CG
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants