Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SaturatedAdditionStep is still using SixteenBitStep #1235

Closed
andyleiserson opened this issue Aug 20, 2024 · 1 comment
Closed

SaturatedAdditionStep is still using SixteenBitStep #1235

andyleiserson opened this issue Aug 20, 2024 · 1 comment

Comments

@andyleiserson
Copy link
Collaborator

This doesn't seem right. Maybe if we're assuming we can't saturate the 32-bit output? But if that's the case, we should eliminate the saturated addition entirely.

The fix is simple, but we ought to have some sort of test or check that the steps are sized appropriately.
@andyleiserson
Copy link
Collaborator Author

Fixed in #1286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andyleiserson