Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images displaying as HTML, but not on RSS feed #8

Open
martinctc opened this issue Apr 22, 2019 · 2 comments
Open

Images displaying as HTML, but not on RSS feed #8

martinctc opened this issue Apr 22, 2019 · 2 comments

Comments

@martinctc
Copy link

Hi Florian, great repo! I've been creating blog posts where images do show properly when viewed on its own, but failed to display in the RSS feed (displays as a black X).

I looked into this and noticed that the image path in the html and the MD file is rendered as something like: "https://martinctc.github.io/blog\images\brace-yourselves.png", where there seems to be something weird going on with the forward and back slashes when FormatPost() is run. The actual code I used in the RMD is as follows:
knitr::include_graphics("../images/brace-yourselves.png")

I then manually replaced the strings "\images" with "/images/", which made the images display properly both on the website and on the RSS feed. Any idea if I was doing something wrong or is this a bug? Thank you ever so much!

@privefl
Copy link
Owner

privefl commented Apr 22, 2019

Thanks.

I'm not sure at all.
I don't really use it on windows and don't really look at the RSS feed.
So, there might be something to improve there.

I'm on vacation right know. Maybe you can look into it. The code is not that long. It might just be some normalizePath() missing somewhere to achieve what you need.

@martinctc
Copy link
Author

Thanks Florian! Apologies I've not had a chance to look at this yet. Main reason is because I'm submitting my blog to r-bloggers and wanted to make sure that the images and plots show up properly if/when they get on the r-bloggers website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants