Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: skore.show_versions() does not show scikit-learn's version #987

Closed
tuscland opened this issue Dec 18, 2024 · 3 comments · Fixed by #1056
Closed

bug: skore.show_versions() does not show scikit-learn's version #987

tuscland opened this issue Dec 18, 2024 · 3 comments · Fixed by #1056
Assignees
Labels
bug Something isn't working
Milestone

Comments

@tuscland
Copy link
Member

tuscland commented Dec 18, 2024

When running skore.show_versions(), the result is:

System:
    python: 3.12.5 (main, Aug  6 2024, 19:08:49) [Clang 15.0.0 (clang-1500.3.9.4)]
executable: /Users/camille/Hacque/probabl/internal_demos/.direnv/python-3.12/bin/python
   machine: macOS-15.2-arm64-arm-64bit

Python dependencies:
        skore: 0.5.0
          pip: 24.2
   setuptools: None
    diskcache: 5.6.3
      fastapi: 0.115.6
 plotly<6,>=5: None
      pyarrow: 18.1.0
         rich: 13.9.4
scikit-learn<1.7: None
        skops: 0.11.0
      uvicorn: 0.34.0

Since we are controlling the upper bound version for scikit-learn, the procedure fails to parse the actual version number.
Same goes for plotly, no version is displayed.

@tuscland tuscland added the bug Something isn't working label Dec 18, 2024
@tuscland tuscland added this to the Skore 0.7 milestone Jan 7, 2025
@glemaitre
Copy link
Member

@rouk1 if you did not make the fix for it, I can have a look. Since we remove the upper bound on scikit-learn, then there is no problem, but we still have the bug for plotly.

@MarieSacksick
Copy link
Contributor

setuptools is also fixed already.

@glemaitre
Copy link
Member

The PR is ready for review by the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants