Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBref] Add unique identifiers to players and teams datasets #728

Open
lorenzodb1 opened this issue Oct 16, 2024 · 4 comments
Open

[FBref] Add unique identifiers to players and teams datasets #728

lorenzodb1 opened this issue Oct 16, 2024 · 4 comments
Labels
enhancement New feature or request FBref Issue or pull request related to the FBref scraper

Comments

@lorenzodb1
Copy link
Contributor

FBref provides a unique 8-character ID for each player and team. This can be particularly useful when working with large datasets. I was wondering if we could include this in the data returned by the scraper.

The following is an example of the IDs provided: fbref.com/en/players/c115db1e/Dailon-Livramento

@lorenzodb1 lorenzodb1 added the enhancement New feature or request label Oct 16, 2024
@probberechts
Copy link
Owner

Yes, good idea! Would you be able to implement this?

@probberechts probberechts added the FBref Issue or pull request related to the FBref scraper label Oct 30, 2024
@MartiONE
Copy link
Contributor

I can do this @probberechts if @lorenzodb1 is OK with it :)

@lorenzodb1
Copy link
Contributor Author

@MartiONE I already have the code somewhere but feel free to do so if you'd like (unless you already did since it took me two weeks to respond to you 😅)

@MartiONE
Copy link
Contributor

Hey @lorenzodb1, lets not do the same work twice then, feel free to go ahead :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FBref Issue or pull request related to the FBref scraper
Projects
None yet
Development

No branches or pull requests

3 participants