Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with LinearGaussiamSMM with time-varying emissions weights #347

Closed
spyectr opened this issue Dec 5, 2023 · 1 comment
Closed

Issue with LinearGaussiamSMM with time-varying emissions weights #347

spyectr opened this issue Dec 5, 2023 · 1 comment

Comments

@spyectr
Copy link

spyectr commented Dec 5, 2023

I am working with the LinearGaussianSSM with time varying emission weights based on the example in Online linear regression using Kalman filtering. I found problems with 1) setting model parameters and sampling data which generates samples with wrong emission dimensions; 2) performing inference with EM, when we freeze emission weights (Trainable==False) to given time-varying values, the model still learns them but with the wrong dimension; 3) fit_sgd gives error messages. I illustrated these issues in this notebook.

@slinderman
Copy link
Collaborator

Hopefully we've fixed these issues through our discussion! See PR #356.

Short story:

  • had to pass lgssm sample code to underlying inference code
  • fit_em doesn't work with trainable=False
  • fit_sgd does work, but there were a few bugs in the notebook you shared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants