Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also generate updateinformation for GitHub Actions, GitHub Workflows #54

Open
probonopd opened this issue Aug 16, 2020 · 8 comments
Open

Comments

@probonopd
Copy link
Owner

The presence of the env GITHUB_WORKFLOW signals that we are running in a GitHub Action. We should do some automatic similar to what we are doing for Travis CI.

https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables

@probonopd
Copy link
Owner Author

GitHub automatically creates a GITHUB_TOKEN secret to use in your workflow. You can use the GITHUB_TOKEN to authenticate in a workflow run.

https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token

@probonopd
Copy link
Owner Author

@probonopd probonopd changed the title Also support GitHub Actions, GitHub Workflows Also generate updateinformation for GitHub Actions, GitHub Workflows Aug 16, 2020
@probonopd
Copy link
Owner Author

probonopd commented Aug 16, 2020

In order to generate updateinformation, we would probably have to internalize what

    - name: Release AppImage
      uses: marvinpinto/action-automatic-releases@latest
      with:
        title: AppImage
        automatic_release_tag: continuous
        prerelease: true
        draft: false
        files: |
          Akira*.AppImage*
        repo_token: ${{ secrets.GITHUB_TOKEN }}

does so that we can be sure that the resulting AppImages are uploaded to the proper location.

Blocked by:
marvinpinto/actions#40

Or, it would be neat if we could parse the above yml from within appimagetool and hence know the value of automatic_release_tag...

@probonopd
Copy link
Owner Author

Work started in 7fab455

Currently it produces wrong update information for continuous builds:

[manjaro@manjaro ~]$ Downloads/altairsim-26-x86_64.AppImage --appimage-updateinformation
gh-releases-zsync|probonopd|altairsim.AppImage|latest|altairsim-*-x86_64.AppImage.zsync

Here, it would need to be continuous rather than latest...

@probonopd probonopd pinned this issue May 7, 2022
@probonopd
Copy link
Owner Author

We should probably also remove support for Travis CI...

@probonopd probonopd unpinned this issue May 7, 2022
@qurious-pixel
Copy link

Is there a way to generate a .zsync file using the static lib builds?

The AppImage was created, but is lacking update information.
Possibly it was built on a local developer machine.
Such an AppImage is fine for local use but should not be distributed.
Please build on one of the supported CI systems like Travis CI
if you want your AppImage to be updatable
and have update notifications published.

I receive the following message when building with GITHUB ACTIONS passing the -u flag.
Trying locally, updateinformation= and -u flag both fail with similar messages.
zsyncmake is in $PATH, embedded in usr/bin, and in the running directory but fails to find it.

Tested with: mkappimage-709-x86_64.AppImage and appimagetool-709-x86_64.AppImage

Using linuxdeploy, linuxdeployqt and appimagetool (non-go) produce the file, but I want to transition to libfuse embedded for Ubuntu 22.04.

@probonopd
Copy link
Owner Author

probonopd commented May 30, 2022

Work started in 7fab455

You need to use appimagetool (NOT mkappimage), do not need -u, and iirc i should automagically guess the correct update information. It's been a while since I had looked at this, though.

Does that work better?

(mkappimage was made for use by other tools that need a low level tool - that's not me...)

@probonopd
Copy link
Owner Author

Here, it would need to be continuous rather than latest...

Sounds similar to

I am also using the continuous tag, but it applied the latest tag.

in probonopd/static-tools#32 (comment) - so this is still wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants