feat: add types

[jamacku]

This should resolve #34

Please note, that this PR doesn't cover ProbotExports:

adapter-github-actions/index.js

Lines 1 to 6 in 8e1f0f8

	const ProbotExports = require("probot");
	const pino = require("pino");
	const { transport } = require("./pino-transport-github-actions");
	module.exports = { ...ProbotExports, run };

[gr2m]

I think this should work

Suggested change

	import { ApplicationFunction } from "probot/lib/types";
	import { ApplicationFunction } from "probot";

Can you check it please?

[jamacku]

I tried that at first, but my IDE was saying: Module '"probot"' has no exported member 'ApplicationFunction'.ts(2305) And When I checked probot's index.d.ts there is only export for ApplicationFunctionOptions but no ApplicationFunction type.

[gr2m]

I think we need to update this line first in probot:
https://github.com/probot/probot/blob/bb068d9ae2407df8a07ffa64dc7d7fb8f01f097a/src/index.ts#L24

[jamacku]

Sure, I'll create PR.

[gr2m]

Already merged, thanks! Now you'll have to bump the minimum version of probot to ^12.1.4

adapter-github-actions/package.json

Line 34 in 8e1f0f8

"probot": "^11.0.6",

Note there were some breaking changes in v12, I'm not sure if any of them affect this adapter:
https://github.com/probot/probot/releases/tag/v12.0.0

[jamacku]

Updated, it seems like these breaking changes doesn't affect adapter, but I found out that there is failing one unit test.

It fails here:

adapter-github-actions/test/index.test.js

Line 99 in 8e1f0f8

expect(output[2].startsWith('::error::{"error":"nope"}%0A{%0A')).toBe(true);

With message:

expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

       97 |     process.stdout.write = origWrite;
       98 |
    >  99 |     expect(output[2].startsWith('::error::{"error":"nope"}%0A{%0A')).toBe(true);
          |                                                                      ^
      100 |
      101 |     expect(mock.activeMocks()).toStrictEqual([]);
      102 |   });

      at Object.<anonymous> (test/index.test.js:99:70)

Is it possible that error message format had changed or am I missing something?

[gr2m]

Děkuju Jan!

[github-actions]

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[jamacku]

Thank you for your work and this awesome tool! 👍