Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL corruption and duplication issues (and fix suggestions) #27

Closed
webknjaz opened this issue Jul 31, 2018 · 18 comments
Closed

URL corruption and duplication issues (and fix suggestions) #27

webknjaz opened this issue Jul 31, 2018 · 18 comments
Labels

Comments

@webknjaz
Copy link

Here's this comment I made: tox-dev/tox#869 (comment)

So it looks like this bot needs improvements in terms of processing inaccessible URLs and outputting duplications.

First two links pointed to different places within GitHub accessible to a logged-in user only. That's why they've got shrunk to just github.com, while my intention was to point to exact pages, which were valid and working URLs.

To fix this, it might make sense to introduce some whitelist of websites, for which bot would preserve original URLs.

Another side-effect of this is duplication of the same resulting URL-preview block in the bottom: we've got invalid 2xgithub.com cards and one correct repository card.

@stale
Copy link

stale bot commented Oct 30, 2018

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Oct 30, 2018
@webknjaz
Copy link
Author

unstale

@stale stale bot removed the wontfix label Oct 31, 2018
@stale
Copy link

stale bot commented Feb 7, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Feb 7, 2019
@webknjaz
Copy link
Author

webknjaz commented Feb 7, 2019

unstale

@stale stale bot removed the wontfix label Feb 7, 2019
@stale
Copy link

stale bot commented May 8, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label May 8, 2019
@webknjaz
Copy link
Author

webknjaz commented May 9, 2019

unstale

@stale stale bot removed the wontfix label May 9, 2019
@stale
Copy link

stale bot commented Aug 7, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Aug 7, 2019
@webknjaz
Copy link
Author

webknjaz commented Aug 7, 2019

yep

@stale stale bot removed the wontfix label Aug 7, 2019
@string-areeb
Copy link

Yeah, it's abandoned. Only way this is getting fixed is to fork

@webknjaz
Copy link
Author

@bkeepers ^

@bkeepers
Copy link
Contributor

I'm no longer actively involved in maintaining Probot.

As the comment asks, is there anything you can do to help move it forward? A pull request would be a good place to start.

@stale
Copy link

stale bot commented Nov 27, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Nov 27, 2019
@webknjaz
Copy link
Author

@bkeepers maybe it makes sense to mark this repo as archived?

@stale stale bot removed the wontfix label Nov 27, 2019
@stale
Copy link

stale bot commented Feb 27, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Feb 27, 2020
@webknjaz
Copy link
Author

Looks like this bot should be disabled because it'll just close everything and if somebody picks it up, they won't see the legitimate issues.

@stale stale bot removed the wontfix label Feb 27, 2020
@stale
Copy link

stale bot commented May 31, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label May 31, 2020
@webknjaz

This comment has been minimized.

@stale stale bot removed the wontfix label May 31, 2020
@stale
Copy link

stale bot commented Aug 29, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Aug 29, 2020
@stale stale bot closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants