Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Document how to create the image of the README #251

Open
5 tasks
tbouffard opened this issue Sep 18, 2023 · 0 comments
Open
5 tasks

[DOC] Document how to create the image of the README #251

tbouffard opened this issue Sep 18, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Sep 18, 2023

Today, we have an image in the README that we update manually.

The script used to create it is not documented in the repository and is only available in the description of Pull Requests. This is not easy to remind and there is a risk of information lost:

Notice that #247 add some style updates that are not documented in existing script (the SVG file was edited manually).

We should put the script in the doc folder instead of keeping it in comments of Pull Requests and probably rename this folder into docs for consistency with other repositories.

Notice that the image currently displayed in the README has been updated manually to be stored as SVG
This is because the SVG content in a webpage contains foreignObject to display the label, and the foreignObject are often not displayed correctly in non browser SVG viewer. For more details, see process-analytics/bpmn-visualization-js#320.

We could avoid to edit the SVG to manage the label positioning by using https://github.com/process-analytics/bpmn-visualization-tools/tree/v0.4.0/bpmn-visualization-svg-screenshots.

Tasks

Preview Give feedback
  1. documentation
  2. documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant