Skip to content

Commit 1f72acd

Browse files
authored
Merge pull request #1655 from sagar-joshi/bug/keyboard-shortcuts-overflow
Fixes overflow problem in overlays
2 parents 27534e0 + 53f7291 commit 1f72acd

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

Diff for: client/styles/components/_keyboard-shortcuts.scss

+2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
.keyboard-shortcuts {
22
padding: #{20 / $base-font-size}rem;
3+
margin-right: #{20 / $base-font-size}rem;
34
padding-bottom: #{40 / $base-font-size}rem;
45
width: #{450 / $base-font-size}rem;
6+
overflow-y: scroll;
57
}
68

79
.keyboard-shortcuts-note {

Diff for: client/styles/components/_preferences.scss

+10-1
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,23 @@
22
width: 100%;
33
width: #{640 / $base-font-size}rem;
44
max-width: 100%;
5-
min-height: #{460 / $base-font-size}rem;
65
max-height: 100%;
76
z-index: 9999;
87
padding: 0 #{20 / $base-font-size}rem #{2 / $base-font-size}rem #{20 /
98
$base-font-size}rem;
109
display: flex;
1110
flex-direction: column;
1211
outline: none;
12+
height: calc(80vh - #{65 / $base-font-size}rem);
13+
max-height: #{460 / $base-font-size}rem;
14+
& .react-tabs {
15+
max-height: 100%;
16+
display: flex;
17+
flex-direction: column;
18+
}
19+
& .react-tabs__tab-panel {
20+
overflow-y: scroll;
21+
}
1322
}
1423

1524
.preferences__exit-button {

0 commit comments

Comments
 (0)