#167 delete files in S3 when deleted in editor

Author: PaliwalSparsh

package.json

@@ -43,7 +43,7 @@
     "extract-text-webpack-plugin": "^1.0.1",
     "file-loader": "^0.8.5",
     "node-sass": "^3.7.0",
-    "nodemon": "^1.9.2",
+    "nodemon": "^1.11.0",
     "postcss-cssnext": "^2.7.0",
     "postcss-focus": "^1.0.0",
     "postcss-loader": "^0.9.1",
@@ -109,6 +109,7 @@
     "redux-thunk": "^2.1.0",
     "request": "^2.76.0",
     "request-promise": "^4.1.1",
+    "s3": "^4.4.0",
     "s3-policy": "^0.2.0",
     "shortid": "^2.2.6",
     "srcdoc-polyfill": "^0.2.0",

server/controllers/file.controller.js

@@ -1,5 +1,6 @@
 import Project from '../models/project';
 import { resolvePathToFile } from '../utils/filePath';
+import { deleteObjectFromS3 } from '../utils/s3Operations';
 
 // Bug -> timestamps don't get created, but it seems like this will
 // be fixed in mongoose soon
@@ -39,6 +40,10 @@ function getAllDescendantIds(files, nodeId) {
 
 function deleteMany(files, ids) {
   ids.forEach(id => {
+    // Delete file from S3 bucket
+    if (!(files.id(id).url === undefined)) {
+      deleteObjectFromS3(files.id(id).url);
+    }
     files.id(id).remove();
   });
 }

server/controllers/project.controller.js

@@ -2,6 +2,7 @@ import Project from '../models/project';
 import User from '../models/user';
 import archiver from 'archiver';
 import request from 'request';
+import { deleteObjectFromS3 } from '../utils/s3Operations';
 
 
 export function createProject(req, res) {
@@ -63,12 +64,24 @@ export function getProject(req, res) {
     });
 }
 
-export function deleteProject(req, res) {
-  Project.remove({ _id: req.params.project_id }, (err) => {
-    if (err) {
-      return res.status(404).send({ message: 'Project with that id does not exist' });
+function deleteFilesFromS3(files) {
+  files.forEach(file => {
+    if (!(file.url === undefined)) {
+      deleteObjectFromS3(file.url);
     }
-    return res.json({ success: true });
+  });
+}
+
+export function deleteProject(req, res) {
+  // Deleting project files form S3
+  Project.findById(req.params.project_id, (err, project) => {
+    deleteFilesFromS3(project.files);
+    Project.remove({ _id: req.params.project_id }, (err) => {
+      if (err) {
+        return res.status(404).send({ message: 'Project with that id does not exist' });
+      }
+      return res.json({ success: true });
+    });
   });
 }
 

server/utils/s3Operations.js

@@ -0,0 +1,31 @@
+import s3 from 's3';
+
+let client = s3.createClient({
+	maxAsyncS3: 20, 
+	s3RetryCount: 3, 
+	s3RetryDelay: 1000,
+	multipartUploadThreshold: 20971520, // this is the default (20 MB) 
+	multipartUploadSize: 15728640, // this is the default (15 MB) 
+	s3Options: {
+		accessKeyId: `${process.env.AWS_ACCESS_KEY}`,
+		secretAccessKey: `${process.env.AWS_SECRET_KEY}`,
+	},
+});
+
+export function deleteObjectFromS3(url) {
+	let objectKey = url.split("/").pop();
+	let params = {
+		Bucket: `${process.env.S3_BUCKET}`,
+		Delete: {
+			Objects: [
+				{
+        			Key: objectKey,
+      			},
+			],
+		},
+	};
+	let del = client.deleteObjects(params);
+	del.on('end', function() {
+		console.log(`${objectKey} file deleted from S3 bucket`);
+	});
+}