Skip to content

Add ability to upload files larger than 5MB? #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siusoon opened this issue Mar 27, 2020 · 4 comments
Open

Add ability to upload files larger than 5MB? #1346

siusoon opened this issue Mar 27, 2020 · 4 comments
Labels
Needs Discussion Requires further conversation or consensus Type:Idea Brainstorming-level suggestion or early-stage proposal

Comments

@siusoon
Copy link

siusoon commented Mar 27, 2020

Screenshot 2020-03-27 at 15 26 15

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

For uploading files (add files), it only check for file size? Currently it doesn't support to upload other LSTM training models (see the dim files as shown on the attached image) I understand this might be due to the issue of file size, but it would be great if the editor allows upload the models for example with size less than 2 MB for example.

@welcome
Copy link

welcome bot commented Mar 27, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented Apr 7, 2020

The web editor is actually checking for the file type, and accepts files up to 5MB. The training files have no file extension, and therefore the web editor doesn't know how to handle them.

Are these training files used with ml5.js? How are they used? Maybe it would also be possible to host them elsewhere and link them to the web editor via URL (if there are no CORS issues).

@siusoon
Copy link
Author

siusoon commented Apr 7, 2020

@catarak Yes it is not a problem to host somewhere but just think would be good if p5.js web editor allows uploading those files as a whole for beginners so they don't have to switch to different places. (yes those files are used with ml5 for the program like charNN: https://github.com/ml5js/ml5-examples/blob/development/p5js/CharRNN/CharRNN_Text/sketch.js)

@catarak
Copy link
Member

catarak commented Apr 9, 2020

Since training datasets can be pretty big (and a big burden of cost on Processing Foundation), I'm wary of allowing users to upload these files, and maybe it would instead make since to be able to link these files to the web editor via a supplied URL. I'm not sure from a UI/UX perspective how to handle CORS issues, and when it would make sense to instead upload the files to the web editor (like in #387). Some interesting stuff to think about.

@catarak catarak changed the title Not support uploading LSTM models as add files Add ability to upload files larger than 5MB? Feb 11, 2021
@catarak catarak added Needs Discussion Requires further conversation or consensus Type:Idea Brainstorming-level suggestion or early-stage proposal labels Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Requires further conversation or consensus Type:Idea Brainstorming-level suggestion or early-stage proposal
Projects
None yet
Development

No branches or pull requests

2 participants