Skip to content

Use one default template #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrewn opened this issue May 10, 2020 · 2 comments · Fixed by #2211
Closed

Use one default template #1423

andrewn opened this issue May 10, 2020 · 2 comments · Fixed by #2211
Labels
Feature Request Priority:High

Comments

@andrewn
Copy link
Member

andrewn commented May 10, 2020 •
edited
Loading

Nature of issue?

  • Existing feature enhancement

Feature enhancement details:

The default HTML for a sketch is defined in multiple places:

  1. client/modules/IDE/reducers/files.js
  2. server/domain-objects/createDefaultFiles.js
  3. server/scripts/examples.js

This makes it a bit tricky to update (see #1396).

We could define the template in one place that the files above use.

Note: When the public API is released, then the examples script (3) won't need to create HTML templates since the API creates default files automatically.
@andrewn andrewn changed the title Use a single default template Use one default template May 10, 2020
@andrewn andrewn mentioned this issue May 10, 2020
Merged
3 tasks
@catarak
Copy link
Member

catarak commented May 22, 2020

This is a great idea. Maybe this could also be handled in tandem with #144?

@SundeepChand
Copy link
Contributor

Hello @catarak, I would like to work on this.

@lindapaiste lindapaiste mentioned this issue May 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Priority:High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup: Single source of default project contents lindapaiste/p5.js-web-editor
3 participants
@andrewn @catarak @SundeepChand