Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sketch entries in a collection don't sort #1652

Closed
jht1493 opened this issue Oct 23, 2020 · 5 comments
Closed

sketch entries in a collection don't sort #1652

jht1493 opened this issue Oct 23, 2020 · 5 comments

Comments

@jht1493
Copy link

jht1493 commented Oct 23, 2020

  • Found a bug viewing a Collection

When viewing sketches in a collection can't sort by name or date.

  • Web browser and version: Chrome and Safari

  • Operating System: MacOS 10.15.7

  • Steps to reproduce this bug:

Open a collection eg: https://editor.p5js.org/jht1493/collections/Gr9aCJs6t
Try clicking on Name or Date header.

Expected: sketches in collection to be sorted

Result: No sorting

@welcome
Copy link

welcome bot commented Oct 23, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@catarak
Copy link
Member

catarak commented Oct 26, 2020

Thank you for reporting! It would be great to make this table sortable. Since there are a few across the app, I think it makes sense to make a reusable, sortable, filterable table component!

@plxity
Copy link
Contributor

plxity commented Oct 28, 2020

@catarak I would like to work this.

@catarak
Copy link
Member

catarak commented Oct 28, 2020

@plxity go ahead! I would suggest working on the reusable table component rather than just fixing this one component.

@catarak
Copy link
Member

catarak commented Feb 12, 2021

I'm going to roll this issue into #1442. Really want to prioritize this!

@catarak catarak closed this as completed Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants