Skip to content

Faux bold applied on functions by the theme #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
romaincazier opened this issue Oct 23, 2024 · 1 comment · Fixed by #3266
Closed

Faux bold applied on functions by the theme #3255

romaincazier opened this issue Oct 23, 2024 · 1 comment · Fixed by #3266

Comments

@romaincazier
Copy link

p5.js version

v1.10.0

What is your operating system?

Mac OS

Web browser and version

No response

Actual Behavior

The theme applies font-weight: 700; to functions. However the corresponding files from Google Fonts (Inconsolota) are not loaded, resulting in the browser applying a faux bold. This issue is especially apparent on Safari where you can see the spacing being off:

Screenshot 2024-10-23 at 15 23 48

Don’t mind the weird code formatting, it’s for a business card 🙃

Expected Behavior

The fix is to change server/views/index.js#L15 to:

<link href='https://fonts.googleapis.com/css?family=Inconsolata:400,700' rel='stylesheet' type='text/css'>
Screenshot 2024-10-23 at 15 24 10

Another fix could be to not change the font-weight of functions

Steps to reproduce

(no steps needed)

Copy link

welcome bot commented Oct 23, 2024

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants