Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.0 Release #6215

Closed
3 of 4 tasks
Qianqianye opened this issue Jun 15, 2023 · 12 comments
Closed
3 of 4 tasks

1.7.0 Release #6215

Qianqianye opened this issue Jun 15, 2023 · 12 comments

Comments

@Qianqianye
Copy link
Contributor

Qianqianye commented Jun 15, 2023

Topic

Hi all, we’d like to release p5.js 1.7.0 in July. Are there any specific issues we should resolve or any pull requests need to get merged before then?

Below are some issues we can focus our efforts on before the 1.7.0 release:

Please let us know if we should label some other issues to the 1.7.0 Milestone. Thank you!

CC @limzykenneth @davepagurek @outofambit @raclim @aferriss @almchung @nickmcintyre @wuyudi @inaridarkfox4231

@Qianqianye Qianqianye pinned this issue Jun 15, 2023
@davepagurek
Copy link
Contributor

This one is a bug only on the main branch currently, so we might want to try to fix it before releasing to avoid a regression (although it means some errors are just less helpful, so we could also decide it's not critical): #6172

One other thought: once we have fixes in for everything here, do you think it's worth it to make a beta release? This is mostly motivated by the fact that I found a bug (#6200) by trying to make a sketch off of a main branch build as opposed to the more focused testing I'd normally do on a custom build. If we make an easier way to test the changes, so you don't have to build and upload p5, maybe we can catch a few more things?

@inaridarkfox4231
Copy link
Contributor

I would like to implement a vector slerp function and a function that performs camera interpolation. I don't know if I'll make it in time...

slerp is a function that does a spherical linear interpolation of two vectors.
3D slerp test

2023-06-18.11-11-34.mp4

You can use the camera interpolation function to smoothly return a camera moved by orbitControl to its initial state, for example.
orbitControl_reset

2023-06-18.11-11-03.mp4

@nickmcintyre
Copy link
Member

The timeline for this release coincides with the first phase of Reference edits for SoD. 2D shapes are complete (#6218) and color is halfway done (#6223):

  • 2D Shapes
  • [] Color
  • [] Foundation
  • [] Math
  • [] Image
  • [] Events
  • [] Typography

I'm happy to create the remaining issues and tie them to 1.7.0.

@limzykenneth
Copy link
Member

limzykenneth commented Jun 30, 2023

@davepagurek
Copy link
Contributor

I'm going to be away for two weeks starting Friday so I'll leave some updates here if other progress is made:

  • I've got one performance improvement PR in review here Improve performance of line rendering #6230 that should be good to go that I'm hoping to get in, but it's not essential that it gets in before release.
  • For the past week my work has been using p5 with a build off of main, which found two new bugs. Fixes for both of those have been merged in now and we haven't noticed anything new just yet. We don't cover all of p5's features though (mostly just WebGL).

@Qianqianye
Copy link
Contributor Author

Qianqianye commented Jul 4, 2023

We are planning to do the 1.7.0 release at the week of July 10 and the next release within 1-2 months (in August or September).

Wondering if there're any PRs from this year's GSoC p5.js contributors that should get merged for 1.7.0 release?

@Ayush23Dash
Copy link
Contributor

We are planning to do the 1.7.0 release at the week of July 10 and the next release within 1-2 months (in August or September).

Wondering if there're any PRs from this year's GSoC p5.js contributors that should should get merged for 1.7.0 release?

Hi,
I believe before the end of August :

  • Few i18n PRs
  • 2-3 PRs for solving FES issues
  • A PR or two for decoupling FES(depends on the discussion with my mentors(to be held in today's meet))

Would be added

@davepagurek
Copy link
Contributor

The image-based lighting project isn't aiming to have code in for this release (maybe the next one though!)

@almchung
Copy link
Contributor

almchung commented Jul 4, 2023

@Qianqianye, I'm sorry if this is already taken care of or is a redundant answer. FES got this bug fix by @Ayush23Dash that has been merged that can be included in the 1.7.0 release:
#6221 FE message reference link bug fix

@katlich112358
Copy link
Contributor

We are planning to do the 1.7.0 release at the week of July 10 and the next release within 1-2 months (in August or September).

Wondering if there're any PRs from this year's GSoC p5.js contributors that should get merged for 1.7.0 release?

I'm planning on having my first round of a11y-fixing PRs sent in by late next week. My contributions can wait until the next version update, just in case there's any blips or revisions needed.

@aceslowman
Copy link
Contributor

@wong-justin @aferriss

After talking with @wong-justin (Shader-Based Filters project), we don't believe that the contributions will quite be ready for 1.7.0, but would like to work towards the goal of the next release.

@Qianqianye
Copy link
Contributor Author

Thank you all! v1.7.0 is just released. We will plan the next release in one month or two.

@Qianqianye Qianqianye unpinned this issue Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants