Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sudo pip install in intro to beautiful soup #1557

Closed
IsaacVerm opened this issue Nov 18, 2019 · 10 comments
Closed

sudo pip install in intro to beautiful soup #1557

IsaacVerm opened this issue Nov 18, 2019 · 10 comments
Assignees
Labels

Comments

@IsaacVerm
Copy link

If you are reporting a problem with a lesson, please try to provide us with the following information:

  • The full title of the lesson: Intro to Beautiful Soup
  • The system you are using: not relevant
  • Version numbers of the relevant software you are using: not relevant
  • The exact steps you took that caused the problem: open the post

The issue I'm having is it seems quite dangerous to encourage running pip install as sudo. It opens a can of worms of security risks.

@svmelton
Copy link
Contributor

Pinging anyone from @programminghistorian/technical-team who may have thoughts here.

@walshbr
Copy link
Contributor

walshbr commented Nov 20, 2019

Yep - this is a good point. @mdlincoln or @ZoeLeBlanc might have suggestions involving pipenv or something instead?

@ZoeLeBlanc
Copy link
Member

Ya using sudo isn't great, but honestly we might want to include guidance on package management just because of the need to update dependencies.

We could set up some guidelines that are lesson agnostic for package management. Maybe something about using conda, pipenv, or virtualenv for python, yarn and npm for node/js, and then something for R?

@acrymble
Copy link

I believe this is in other lessons too.

I admit not understanding why this is a bad idea in this specific context.

@walshbr
Copy link
Contributor

walshbr commented Nov 21, 2019

The top comment here I think addresses it - https://askubuntu.com/questions/802544/is-sudo-pip-install-still-a-broken-practice.

@svmelton
Copy link
Contributor

svmelton commented Dec 3, 2019

Are there other thoughts on @ZoeLeBlanc's suggestion to set up guidelines for package management? It seems like a good suggestion to me. Is there anyone who could take this on?

@walshbr
Copy link
Contributor

walshbr commented Dec 3, 2019

I think it's a good idea, but I don't have the expertise to do it. I mostly just know that the way I manage my Python installation is not a good practice. 😄

@svmelton
Copy link
Contributor

The proposed solution brought forward during #1589 was to flag sudo if authors use it in future lessons, and encouraging users to open a ticket with PH if they have questions about using sudo.

@mdlincoln
Copy link
Contributor

@svmelton anything need to change in our reviewer guidelines for this? Or can we close it?

@svmelton
Copy link
Contributor

svmelton commented Mar 2, 2020

I think we can close this!

@svmelton svmelton closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants