Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2023-0005: tokio::io::ReadHalf<T>::unsplit is Unsound #587

Closed
github-actions bot opened this issue Apr 18, 2023 · 3 comments · Fixed by #593
Closed

RUSTSEC-2023-0005: tokio::io::ReadHalf<T>::unsplit is Unsound #587

github-actions bot opened this issue Apr 18, 2023 · 3 comments · Fixed by #593
Labels

Comments

@github-actions
Copy link
Contributor

tokio::io::ReadHalf&lt;T&gt;::unsplit is Unsound

Details
Status unsound
Package tokio
Version 0.2.25
URL tokio-rs/tokio#5372
Date 2023-01-11

tokio::io::ReadHalf&lt;T&gt;::unsplit can violate the Pin contract

The soundness issue is described in the tokio/issues#5372

Specific set of conditions needed to trigger an issue (a !Unpin type in ReadHalf)
is unusual, combined with the difficulty of making any arbitrary use-after-free
exploitable in Rust without doing a lot of careful alignment of data types in
the surrounding code.

The tokio feature io-util is also required to be enabled to trigger this
soundness issue.

Thanks to zachs18 reporting the issue to Tokio team responsibly and taiki-e
and carllerche appropriately responding and fixing the soundness bug.

Tokio before 0.2.0 used futures 0.1 that did not have Pin, so it is not
affected by this issue.

See advisory page for additional details.

@diconico07 diconico07 mentioned this issue Apr 27, 2023
8 tasks
@github-actions
Copy link
Contributor Author

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

@github-actions
Copy link
Contributor Author

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

Copy link
Contributor Author

Issue has been automatically marked as stale due to inactivity for 90 days. Update the issue to remove label, otherwise it will be automatically closed.

@github-actions github-actions bot added the stale label Jan 19, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Akri Roadmap Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant