Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Darwin framework needs to safely shut down subscriptions when controllers shut down #21198

Closed
bzbarsky-apple opened this issue Jul 25, 2022 · 3 comments
Closed

Darwin framework needs to safely shut down subscriptions when controllers shut down #21198

bzbarsky-apple opened this issue Jul 25, 2022 · 3 comments
Assignees
@bzbarsky-apple
Labels
darwin V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

When a Mater.framework controller shuts down, any live subscriptions associated with its fabric should also get cleanly shut down. Right now we would end up with dangling pointers and crashes in that scenario.

Proposed Solution

Have the framework track subscriptions and shut them down.
@bzbarsky-apple bzbarsky-apple mentioned this issue Jul 25, 2022
Closed
@bzbarsky-apple
Copy link
Contributor Author

@jtung-apple

@woody-apple
Copy link
Contributor

Darwin Issue Review: We believe this is resolved, closing for now.

@bzbarsky-apple
Copy link
Contributor Author

This is handled by chip::DeviceController now after #22323.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
darwin V1.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@woody-apple @nivi-apple @bzbarsky-apple @jtung-apple