Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #define for CHIP_CONFIG_ENABLE_RELIABLE_MESSAGING #2215

Closed
woody-apple opened this issue Aug 18, 2020 · 3 comments · Fixed by #2327
Closed

Remove #define for CHIP_CONFIG_ENABLE_RELIABLE_MESSAGING #2215

woody-apple opened this issue Aug 18, 2020 · 3 comments · Fixed by #2327
Assignees
@yufengwangca
Milestone
V1.0

Comments

@woody-apple
Copy link
Contributor

Should we just remove this define? We need reliable messaging in CHIP :)

Originally posted by @woody-apple in #2206
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

@woody-apple woody-apple added this to the V1.0 milestone Aug 18, 2020
@yufengwangca yufengwangca self-assigned this Aug 24, 2020
@yufengwangca
Copy link
Contributor

Confirmed with Grant, this feature is mandatory for all products, we can remove this feature flag

@yufengwangca
Copy link
Contributor

The decision whether to use RMP or UDP is made at the Binding level, when Binding is created there will be a setting whether RMP should be used for this protocol

@yufengwangca yufengwangca mentioned this issue Aug 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yufengwangca yufengwangca

Labels
None yet
Projects
None yet
Milestone
V1.0
Development

Successfully merging a pull request may close this issue.

Remove build flag CHIP_CONFIG_ENABLE_RELIABLE_MESSAGING since RMP is …
2 participants
@yufengwangca @woody-apple