Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] [privacy] Messages should not enable P flag if privacy is not applied #22426

Closed
turon opened this issue Sep 6, 2022 · 0 comments · Fixed by #22425
Closed

[1.0] [privacy] Messages should not enable P flag if privacy is not applied #22426

turon opened this issue Sep 6, 2022 · 0 comments · Fixed by #22425
Assignees
@turon
Labels
crypto group messaging spec Mismatch between spec and implementation V1.0

Comments

@turon
Copy link
Contributor

turon commented Sep 6, 2022 •
edited
Loading

Description

Group messages are being encoded with the privacy flag but not actually applying privacy obfuscation. This will break the feature without a path for forward compatibility.

Reproduction steps

Per code inspection:

  1. PrivacyDecrypt and PrivacyEncrypt are not integrated into message decode/encode path yet
  2. IsValidGroupMsg calls HasPrivacyFlag.
  3. SessionManager::PrepareMessage sets kPrivacyFlag for kGroupOutgoing.

Bug prevalence

always

GitHub hash of the SDK that was being used

58fd10a

Platform

core

Platform Version(s)

No response

Type

Core SDK Interopability Issue

Anything else?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turon turon

Labels
crypto group messaging spec Mismatch between spec and implementation V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[privacy] Don't enable privacy when privacy is not supported. turon/connectedhomeip
1 participant
@turon