ASR platform manager synchronization seems to be completely broken

[bzbarsky-apple]

See #26361 (review)

@tx2rx @andy31415

[bzbarsky-apple]

Also, where is _TryLockChipStack implemented for ASR? I don't see it.

[bzbarsky-apple]

Note that I only reviewed PlatformManager and TimeSupport from #26361 and both were broken. I have extremely low confidence in any of the rest of it...

[tx2rx]

Also, where is _TryLockChipStack implemented for ASR? I don't see it.

Because in src/ , that is not used before. Just in case ,we will add it soon later

[tx2rx]

In addition, src/include/platform/internal/GenericPlatformManagerImpl_FreeRTOS.ipp may cause the same problem:

    BaseType_t eventReceived = pdFALSE;
    {
        // Unlock the CHIP stack, allowing other threads to enter CHIP while
        // the event loop thread is sleeping.
        StackUnlock unlock;
        eventReceived = xQueueReceive(mChipEventQueue, &event, waitTime);
    }

StackLock lock; // should it open lock again? @bzbarsky-apple

[bzbarsky-apple]

// should it open lock again?

It does, in the destructor of the StackLock. And temporarily while the StackUnlock is in scope, because the thread can end up sleeping under that xQueueReceive call, and sleeping should not be done with a lock held.