Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.2] address TSC review comments #28930

Closed
bzbarsky-apple opened this issue Aug 28, 2023 · 2 comments · Fixed by #29396
Closed

[1.2] address TSC review comments #28930

bzbarsky-apple opened this issue Aug 28, 2023 · 2 comments · Fixed by #29396
Assignees
@cecille
Labels
bug Something isn't working needs triage

Comments

@bzbarsky-apple
Copy link
Contributor

Reproduction steps

See #28418 (review) @cecille

Bug prevalence

Always

GitHub hash of the SDK that was being used

master

Platform

core

Platform Version(s)

No response

Type

Common Cluster Logic

Anything else?

No response
@bzbarsky-apple bzbarsky-apple added bug Something isn't working needs triage labels Aug 28, 2023
@bzbarsky-apple
Copy link
Contributor Author

@cecille In particular, if I am reading the data at #28418 (comment) right the TSC bits added 13-15KB of flash on the constrained platforms.... That seems very excessive.

@bzbarsky-apple
Copy link
Contributor Author

@fessehaeve If you have bandwidth to look at this before @cecille that would be great...

@cecille cecille moved this from Todo to In Progress in [Feature] Time Sync Sep 22, 2023
@cecille cecille mentioned this issue Sep 22, 2023
Merged
@mergify mergify bot closed this as completed in #29396 Sep 26, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in [Feature] Time Sync Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cecille cecille

Labels
bug Something isn't working needs triage
Projects
[Feature] Time Sync
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Time sync: Remove ClusterStateCache cecille/connectedhomeip
2 participants
@cecille @bzbarsky-apple