Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telink] -Wundef errors in config headers #29593

Open
bzbarsky-apple opened this issue Oct 5, 2023 · 1 comment
Open

[Telink] -Wundef errors in config headers #29593

bzbarsky-apple opened this issue Oct 5, 2023 · 1 comment

Comments

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Oct 5, 2023

Reproduction steps

Enable -Wundef. https://github.com/project-chip/connectedhomeip/actions/runs/6419947071/job/17430925696?pr=29582

INFO    ../../../../src/platform/telink/CHIPPlatformConfig.h:65:5: error: "CONFIG_PM" is not defined, evaluates to 0 [-Werror=undef]
INFO       65 | #if CONFIG_PM
INFO          |     ^~~~~~~~~
...
INFO    ../../../../src/system/SystemConfig.h:736:62: error: "CONFIG_NET_SOCKETS_POSIX_NAMES" is not defined, evaluates to 0 [-Werror=undef]
INFO      736 | #if CHIP_SYSTEM_CONFIG_USE_SOCKETS && defined(__ZEPHYR__) && CONFIG_NET_SOCKETS_POSIX_NAMES
INFO          |                                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
INFO    cc1plus: note: unrecognized command-line option '-Wno-unknown-warning-option' may have been intended to silence earlier diagnostics

And also in https://github.com/project-chip/connectedhomeip/actions/runs/6419947054/job/17430927196?pr=29582

../../../../../../src/platform/Zephyr/ThreadStackManagerImpl.h:32:6: error: "CONFIG_SOC_SERIES_RISCV_TELINK_B9X" is not defined, evaluates to 0 [-Werror=undef]
   32 | #if !CONFIG_SOC_SERIES_RISCV_TELINK_B9X
      |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

which looks like Telink code breaking other platforms (in this case nrfconnect).

Are these headers failing to include something that would define the relevant macros?

Platform

other

Platform Version(s)

No response

Type

CI tested

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

No response

@bzbarsky-apple
Copy link
Contributor Author

@s07641069 See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant