Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant TC acknowledgement requirement flag #36965

Open
swan-amazon opened this issue Jan 6, 2025 · 0 comments · May be fixed by #36966
Open

Remove redundant TC acknowledgement requirement flag #36965

swan-amazon opened this issue Jan 6, 2025 · 0 comments · May be fixed by #36966

Comments

@swan-amazon
Copy link
Contributor

swan-amazon commented Jan 6, 2025

Background

Currently, there's a boolean flag in the commissioning flow that controls whether TC (Terms & Conditions) acknowledgement is required. This flag is redundant because:

  • TC acceptance is now a mandatory pre-condition for commissioning
  • The delayed TC acceptance flow has been removed from the system
  • The flag no longer serves any functional purpose

Proposed Changes

  • Remove the boolean flag that controls TC acknowledgement requirement
  • Keep the actual TC acknowledgement state tracking (this remains necessary)
  • Update related documentation and tests

Technical Notes

  • This is a cleanup task with no functional changes
  • The original flag was implemented to support a now-removed feature where users could provide TC acceptance after starting the commissioning process
  • Since TC acceptance is now required upfront, this additional control flag is unnecessary

Impact

  • No user-facing changes
  • Code simplification
  • Reduced maintenance overhead

Related

Link to original PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant