Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warnings about missing clusters for Air Quality? #1283

Open
olavt opened this issue Mar 22, 2024 · 2 comments
Open

Incorrect warnings about missing clusters for Air Quality? #1283

olavt opened this issue Mar 22, 2024 · 2 comments

Comments

@olavt
Copy link

olavt commented Mar 22, 2024

Issue is decribed here:

https://community.silabs.com/s/question/0D5Vm0000066HePKAU/incorrect-zap-tool-warnings?language=en_US

@paulr34
Copy link
Collaborator

paulr34 commented Jun 14, 2024

@brdandu would know best about this

@brdandu
Copy link
Collaborator

brdandu commented Jun 14, 2024

So the warnings are actually coming from the Matter XML. Whatever is the default state of the device type. In this case it is

<deviceType> <name>MA-air-quality-sensor</name> <domain>CHIP</domain> <typeName>Matter Air Quality Sensor</typeName> <profileId editable="false">0x0103</profileId> <deviceId editable="false">0x002C</deviceId> <class>Simple</class> <scope>Endpoint</scope> <clusters lockOthers="true"> <include cluster="Descriptor" client="false" server="true" clientLocked="true" serverLocked="true"></include> <include cluster="Identify" client="false" server="true" clientLocked="true" serverLocked="true"> <requireAttribute>IDENTIFY_TIME</requireAttribute> <requireAttribute>IDENTIFY_TYPE</requireAttribute> <requireCommand>Identify</requireCommand> </include> <include cluster="Air Quality" client="false" server="true" clientLocked="true" serverLocked="true"></include> <include cluster="Temperature Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Relative Humidity Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Carbon Monoxide Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Carbon Dioxide Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Nitrogen Dioxide Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Ozone Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Formaldehyde Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="PM1 Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="PM2.5 Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="PM10 Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Radon Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> <include cluster="Total Volatile Organic Compounds Concentration Measurement" client="false" server="true" clientLocked="true" serverLocked="false"></include> </clusters> </deviceType>

which includes Radon Concentration Measurement server even though it may not be mandatory. ZAP wants to assist the user about what is coming from the xml. We can look into improving the warning system to also say Radon Concentration Measurement server cluster is required by default but not mandatory if that improves the user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants