Bug: Incorrect arguments to mysqld_stmt_execute

[AvaN0x]

Development Issue

No

Phone Version

1.2.1

Issue Description

Issue caused by MySQL version 8.0.22 and above (currently using 8.0.27). Whenever a query has a LIMIT ? there is the error "Incorrect arguments to mysqld_stmt_execute".

This issue has a fix that you can find here sidorares/node-mysql2#1239 (comment).
Basically, every time there is a LIMIT ? with a number as value there will be the error. Having it passed as a string fixes it. (Same issue for the OFFSET ?)

So for example here :

npwd/resources/server/messages/messages.db.ts

Lines 44 to 48 in 165c90e

	const [results] = await DbInterface._rawExec(query, [
	dto.conversationId,
	MESSAGES_PER_PAGE,
	offset,
	]);

Having this would fix the error :

    const [results] = await DbInterface._rawExec(query, [
      dto.conversationId,
      MESSAGES_PER_PAGE + "",
      offset + "",
    ]);

Issue Reproduction

1. Update your mysql to 8.0.22 or above
2. Create a conversation
3. Try to open the conversation, you should get an error saying "Impossible to find messages"
   
   And the server console should show these :
   
   

[itschip]

Fixed in 14c82ee and 90133a6