Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc64le/multi-arch support for operator image #220

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

jcho02
Copy link
Contributor

@jcho02 jcho02 commented Oct 27, 2023

IBM Power (ppc64le) and multi-arch build for the operator image.
Also including ppc64le support tag to the CSV file for operator appear on the OperatorHub in ppc64le arch based OCP clusters.

Makefile Outdated Show resolved Hide resolved
@jcho02
Copy link
Contributor Author

jcho02 commented Oct 27, 2023

Thank you Michael for the feedback, made changes accordingly to your comments

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ee6d06d) 85.12% compared to head (1873e5b) 85.12%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files          13       13           
  Lines        2730     2730           
=======================================
  Hits         2324     2324           
  Misses        325      325           
  Partials       81       81           
Flag Coverage Δ
unittests 85.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6d06d...1873e5b. Read the comment docs.

@maskarb
Copy link
Member

maskarb commented Oct 31, 2023

@jcho02
This PR looks totally fine to me, but before we merge it, we need to figure out how we are going to actually build the multi-arch images. The upstream images are currently built in quay.io when PRs are merged and releases are published. It doesn't seem like the quay.io runners support multi-arch image building, so we will need to switch to something else (like a Github action) to accomplish that.

@jcho02
Copy link
Contributor Author

jcho02 commented Nov 6, 2023

Added a workflow to build and push images onto quay

@maskarb
Copy link
Member

maskarb commented Nov 30, 2023

@jcho02 I went ahead and implemented a build/push pipeline in this PR: #231, so feel free to back those changes out of this PR.

If you could run the latest image (quay.io/project-koku/koku-metrics-operator:latest or quay.io/project-koku/koku-metrics-operator@sha256:623a054331239a17c8aaeaa906a7ee7407a6e4ea906b24c1f2c706351b804b4b) on Power to confirm it compiles correctly for that arch, that would be great.

@jcho02
Copy link
Contributor Author

jcho02 commented Dec 1, 2023

Thanks @maskarb I verified the image and the operator builds on power platforms.

Signed-off-by: Jason Cho <jason.cho2@ibm.com>
@jcho02 jcho02 reopened this Dec 1, 2023
@maskarb maskarb merged commit c930a50 into project-koku:main Jan 11, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants