Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make oak_abi no_std compatible #638

Closed
blaxill opened this issue Feb 24, 2020 · 2 comments
Closed

Make oak_abi no_std compatible #638

blaxill opened this issue Feb 24, 2020 · 2 comments

Comments

@blaxill
Copy link
Contributor

blaxill commented Feb 24, 2020

Currently oak/server/rust/oak_abi requires std as the generated protobuf files use std. The rust runtime is intended to be no_std compatible and so needs oak_abi to also be no_std compatible. The options available in approximate order of effort to benefit:

  • Patch the generated generated protobuf files
  • Patch the upstream protobuf generator to be no_std compatible
  • Replace the protobuf files with manual instantiations (at the cost of losing auto-synchronisation for oak abi definitions)
@tiziano88
Copy link
Collaborator

Another alternative would be to instead define those constants in a .h file, and use rust-bindgen to generate Rust bindings for them (they would look like separate consts rather than actual enums though, which is not great).

@daviddrysdale
Copy link
Contributor

No longer relevant – we're not targetting a no_std build of Rust code any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants